[Tcl-bugs] [ tktoolkit-Bugs-2900121 ] LineDeleteCoords has an inverted test

[SourceForge.net <no...@so...>]

Bugs item #2900121, was opened at 2009-11-18 23:23
Message generated for change (Tracker Item Submitted) made by ferrieux
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112997&aid=2900121&group_id=12997

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 05. Canvas Items
Group: None
Status: Open
Resolution: None
Priority: 9
Private: No
Submitted By: Alexandre Ferrieux (ferrieux)
Assigned to: Donal K. Fellows (dkf)
Summary: LineDeleteCoords has an inverted test

Initial Comment:
In the LineDeleteCoords function, the test to decide whether or not to do an optimized refresh (TK_ITEM_DONT_REDRAW) is inverted. 
It is currently:

  if ((first1 < 2) && (last1 >= length-2)) { don't redraw }

it should read the converse:

  if (!(first1 < 2) && (last1 >= length-2))) { don't redraw }

Note that this is not easy to exhibit in a script. But thanks to bug 2899685 (imove) it became conspicuous.

Attaching the obvious patch. Prio9 because trivial.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112997&aid=2900121&group_id=12997