Menu
▾
▴
[Tcl-bugs] [ tcl-Patches-2891616 ] TIP 357 draft changes
|
From: SourceForge.net <no...@so...> - 2009-11-04 02:06:57
|
Patches item #2891616, was opened at 2009-11-03 21:06 Message generated for change (Tracker Item Submitted) made by kennykb You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=2891616&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 40. Dynamic Loading Group: TIP Implementation Status: Open Resolution: None Priority: 5 Private: No Submitted By: Kevin B KENNY (kennykb) Assigned to: Kevin B KENNY (kennykb) Summary: TIP 357 draft changes Initial Comment: This patch set reflects where I am with TIP 357 implementation. Notes: (1) [unload] of modules loaded from VFS is totally untested in the test suite. And I *know* it won't work with these patches, because I haven't done anything about wrapping the FSDivertLoad structure (in tclLoadUtil.c) into a Tcl_LoadHandle. That will have to be done (and a test case added) before this ships. (2) There has been no attempt to test, or even build, on a platform other than Win32 and Linux-ix86. (3) The code will not work for preloading DLLs because the DLL name changes to a TclpTempFileName when it gets copied to the native filesystem, losing the identity of the DLL symbols for cross-linking. (4) patthoyts, mistachkin, and tclguy are talking about making load-from-memory work on Windows. (5) jenglish wants Tcl_LoadFile to fail (and unload the library) if any symbol is missing. (Optional symbols can be processed with Tcl_FindSymbol.) I'm willing to go along with that, but haven't done it. When we do, the calling code in the [load] command needs to be adapted to use Tcl_FindSymbol for the _SafeInit, _Unload and _SafeUnload entry points. (6) There are no man pages for the new APIs. (7) The code probably s*ks and definitely needs another pair of eyeballs or three. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=2891616&group_id=10894 |