[Tcl-bugs] [ tktoolkit-Patches-2819620 ] Improvements in Aqua ttk theme

[SourceForge.net <no...@so...>]

Patches item #2819620, was opened at 2009-07-10 06:59
Message generated for change (Comment added) made by hobbs
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312997&aid=2819620&group_id=12997

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 66. Aqua Window Operations
Group: None
Status: Open
Resolution: None
Priority: 7
Private: No
Submitted By: Kevin Walzer (wordtech)
Assigned to: Daniel A. Steffen (das)
Summary: Improvements in Aqua ttk theme

Initial Comment:
This patch to ttkMacOSXTheme.c: makes two improvements to the Aqua ttk theme:

1. It fixes the "selected" state of the ttk::treeview column header to render in standard "Aqua" blue only. Previously the "selected" state rendered in the "Aqua" blue and also drew an "up" arrow without a corresponding "down" arrow if the column header were clicked on. This change allows the appropriate  up/down arrow to be implemented at the script level, if necessary. The result is a more-native appearance under Aqua. 

2. It modernizes the appearance of the notebook tab under Aqua, cf http://www.codebykevin.com/mac-tabs.png, to use the style that became the system standard in Mac OS X 10.3, released in 2003. Previously the notebook tabs were drawn with an older style that is no longer widely used. 

----------------------------------------------------------------------

>Comment By: Jeffrey Hobbs (hobbs)
Date: 2009-07-15 08:26

Message:
Point 4 is not correct.  The 'ttk::style theme use' should be correct in
8.6, but may or may not have been backported to 8.5.  However, that command
does not return 0/1, it will error, so the alternative is definitely not
right.

----------------------------------------------------------------------

Comment By: Kevin Walzer (wordtech)
Date: 2009-07-15 06:46

Message:
1. Modern notebook appearance works correctly.
2. ttk::treeview arrows/header work as expected with up and down arrows.
3. Changes to ttk::treeview work correctly with updates in Tablelist
widget to draw headers with "selected" state with arrow added at script
level by Tablelist.
4. One minor update to mclist.tcl. Line 115, "if {[ttk::style theme use]
eq 'aqua'"} causes an error: the "style theme use" command is looking for
the name of a theme. Changing this line to 
     if {[ttk::style theme use aqua] == 0} {
gets the demo working correctly. Please update the diff. 

With the final adjustment to mclist.tcl, this is ready to commit. 


----------------------------------------------------------------------

Comment By: Daniel A. Steffen (das)
Date: 2009-07-14 19:58

Message:
revised patch attached, adding the following features:
- ttk:treeview: both "selected" and "alternate" states draw unadorned
highlighted treeheaders, except when "user1" state is also set, in which
case "selected" draws the header with down arrow and "alternate" the header
with up arrow
- mclist demo updated to use the native sort arrow support when aqua theme
is active
- modern notebook appearance corrected to vertically center tabs on
groupbox. Adjusted internal & external padding of notebook and of tabs to
match InterfaceBuilder. Added tabmargins to ensure minimal amount of
groupbox is shown next to tabs.

Please verify this works correctly for you, will commit tomorrow if I hear
no objections

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312997&aid=2819620&group_id=12997