[Tcl-bugs] [ expect-Bugs-2809496 ] found a possible memory leak

[SourceForge.net <no...@so...>]

Bugs item #2809496, was opened at 2009-06-20 15:25
Message generated for change (Tracker Item Submitted) made by ettlmartin
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=113179&aid=2809496&group_id=13179

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: orbitcowboy (ettlmartin)
Assigned to: Nobody/Anonymous (nobody)
Summary: found a possible memory leak

Initial Comment:
Hello,

i have checked the sources of expect-5.44.1 with the static code analysis tool cppcheck. The tool brought up a little issue in file:"pty_unicos.c".
It prints the following output:

[expect-5.44.1/pty_unicos.c:94]: (error) No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.
[expect-5.44.1/pty_unicos.c:92]: (error) No pair for character ("). Can't process file. File is either invalid or unicode, which is currently not supported.


Take a look at line 92 and 94 of pty_uinicos.c:

#ifdef STTY_READS_STDOUT
    sprintf(buf,%s %s > %s",STTY_BIN,s,name);
#else
    sprintf(buf,%s %s < %s",STTY_BIN,s,name);
#endif

To mee it looks like the analysis tool is right?

The corrected code is:

#ifdef STTY_READS_STDOUT
    sprintf(buf,"%s %s > %s",STTY_BIN,s,name);
#else
    sprintf(buf,"%s %s < %s",STTY_BIN,s,name);
#endif

Best regards

Ettl Martin

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=113179&aid=2809496&group_id=13179