[Tcl-bugs] [ tcl-Bugs-990457 ] Unix Tcl_Exit behavior incorrect with TCL_THREADS

[SourceForge.net <no...@so...>]

Bugs item #990457, was opened at 2004-07-13 21:52
Message generated for change (Comment added) made by dkf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=990457&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 02. Event Loops
Group: obsolete: 8.5a2
>Status: Pending
Resolution: Remind
Priority: 7
Private: No
Submitted By: Joe Mistachkin (mistachkin)
>Assigned to: Alexandre Ferrieux (ferrieux)
Summary: Unix Tcl_Exit behavior incorrect with TCL_THREADS

Initial Comment:

in "generic/tclEvent.c" near line 644, the code reads:

	/* use default handling */
	Tcl_Finalize();
	TclpExit(status);
	Tcl_Panic("OS exit failed!");

the above code should read:

	/* use default handling */
	Tcl_Finalize();
#ifdef TCL_THREADS
	TclpThreadExit(status);
#else
	TclpExit(status);
#endif
	Tcl_Panic("OS exit failed!");

This fixes an annoying memory leak when TCL_THREADS is
enabled.  I believe this change should be backported to
core-8-4-branch.



----------------------------------------------------------------------

>Comment By: Donal K. Fellows (dkf)
Date: 2009-06-18 09:20

Message:
Believed fixed (i.e. other probably-related bugs are fixed) so moved to
Pending...

----------------------------------------------------------------------

Comment By: Alexandre Ferrieux (ferrieux)
Date: 2009-06-17 21:05

Message:
Now 2001201 has been applied, please retest.

----------------------------------------------------------------------

Comment By: Joe Mistachkin (mistachkin)
Date: 2008-10-02 20:31

Message:
Also see 2001201.


----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2006-03-10 05:57

Message:
Logged In: YES 
user_id=80530


Tcl's finalization has been revised.

Joe's patch no longer causes
crashes on exit running the test suite
on HEAD.

However, now that the crashes are
gone, several failing tests are
revealed (see below).  Looks like
the proposed patch changes the
behavior of [exit] in an [exec]-ed
process in an incompatible way.

Failing tests are:

event-10.1
exec-9.{3,4}
Tcl_Main-3.{1-4}
tcltest-1.{1,2}
tcltest-22.1



----------------------------------------------------------------------

Comment By: Joe Mistachkin (mistachkin)
Date: 2005-05-31 06:26

Message:
Logged In: YES 
user_id=113501


It's crashing on exit.  This is still a valid bug because if
you create a thread using Tcl_CreateThread and invoke [exit]
(or Tcl_Exit), pthread_exit (or the equiv on Win32) is never
called.  This is technically a leak.  A slightly more
complex solution to this is required and I will start
working on it soon.

----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2005-03-03 21:04

Message:
Logged In: YES 
user_id=72656

On Linux, apply patch and build the head with
--enable-threads.  Do make test.  Watch it bomb all over the
place:

Tests began at Thu Mar 03 13:03:11 -0800 2005
append.test
Test file error: child killed: segmentation violation
appendComp.test
Test file error: child killed: segmentation violation
assocd.test
Test file error: child killed: segmentation violation
async.test
Test file error: child killed: segmentation violation
....


----------------------------------------------------------------------

Comment By: Joe Mistachkin (mistachkin)
Date: 2005-03-03 07:52

Message:
Logged In: YES 
user_id=113501


Jeff, what platform is "make test" producing failures on and
what are the failures?  I'm trying to pin down the real root
cause.



----------------------------------------------------------------------

Comment By: Joe Mistachkin (mistachkin)
Date: 2004-11-30 17:19

Message:
Logged In: YES 
user_id=113501

My proposed fix may cause the test suite to crash, however,
the current code is wrong and can cause quite a few
memory/resource leaks.


----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2004-11-17 18:05

Message:
Logged In: YES 
user_id=72656

This suggestion causes all sorts of crashes in 'make test'.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=990457&group_id=10894