From: SourceForge.net <no...@so...> - 2009-04-09 15:33:46
|
Bugs item #2486824, was opened at 2009-01-04 20:42 Message generated for change (Comment added) made by dgp You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2486824&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 07. Variables Group: current: 8.6b1 Status: Open Resolution: None Priority: 5 Private: No Submitted By: Stuart Cassoff (stwo) Assigned to: miguel sofer (msofer) Summary: "upvar" in [global]'s err msg. Initial Comment: % namespace eval n { proc p {} { global a(b) }; p } bad variable name "a(b)": upvar won't create a scalar variable that looks like an array element ---------------------------------------------------------------------- >Comment By: Don Porter (dgp) Date: 2009-04-09 11:33 Message: Note also this apparent inconsistency: % proc demo {} {global a(k)} % demo bad variable name "a(k)": upvar won't create a scalar variable that looks like an array element % global a(k) % I would think that varNames that look like array elements ought to be always forbidden as arguments to [global]. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2009-04-02 15:38 Message: Another reason it's generally a bad idea to include a command name in an error message is that Tcl commands can be [rename]d. Let the error message describe the error only; leave it to -errorinfo to describe the context. ---------------------------------------------------------------------- Comment By: Alexandre Ferrieux (ferrieux) Date: 2009-01-05 04:30 Message: Agreed, since the overall style of error messages is to omit the command name, and being smart about it involves an ugly switch on the flags parameter in the common code. For consistency we might do the same to 'upvar won't create namespace variable that refers to procedure variable' even though, by accident, this message occurs in more constrained contexts. Don't forget the three tests to update accordingly :-) ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2009-01-05 04:25 Message: I suggest just getting rid of the word "upvar" from that message. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2486824&group_id=10894 |