[Tcl-bugs] [ tcl-Bugs-2255235 ] platform::shell::generic is broken

[SourceForge.net <no...@so...>]

Bugs item #2255235, was opened at 2008-11-10 04:01
Message generated for change (Comment added) made by andreas_kupries
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2255235&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 54. Configuration Reporting
Group: current: 8.5.5
Status: Open
Resolution: None
Priority: 8
Private: No
Submitted By: Ulrich Ring (uring)
Assigned to: Andreas Kupries (andreas_kupries)
Summary: platform::shell::generic is broken

Initial Comment:

the following 2 commands are broken:

platform::shell::generic
platform::shell::identity

see file: library/platform/shell.tcl - installed
as a tcl-module in tcl8/8.4/shell-1.1.3.tm

actually, the bug is located in the 3rd code line
of the internal procedure ::platform::shell::LOCATE

     foreach {cmd base} $pl break

this line tries to extract the pathname of the
sourced module platform-1.0.3.tm, which is expected
to be the 2nd item of the list returned by the
previous command

 [package ifneeded platform [package require platform]]

nowadays we find something more complex like:
"package provide platform 1.0.3; source -encoding ...".
so, variable base becomes "provide", which is not what
we want.

suggested PATCH: use

  set base [lindex $pl end]

to get the filepath.

regards,
Ulrich

----------------------------------------------------------------------

Comment By: Andreas Kupries (andreas_kupries)
Date: 2008-11-10 09:58

Message:
Both HEAD and 8.5 branch head are now updated with the suggested patch.
Bumped package to 1.1.4, and updated docs and Makefiles for that as well.

----------------------------------------------------------------------

Comment By: Andreas Kupries (andreas_kupries)
Date: 2008-11-10 09:41

Message:
Thanks Ulrich. You are quite right. The latest changes to the provide
command generated by tm.tcl in the core require us to update and change the
implementation of LOCATE as well. I will do that now and add a
cross-reference to tm.tcl so that this will not be forgotten should tm.tcl
be changed again in the future.


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=2255235&group_id=10894