From: SourceForge.net <no...@so...> - 2008-11-05 15:01:42
|
Patches item #1611359, was opened at 2006-12-08 09:08 Message generated for change (Comment added) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1611359&group_id=12997 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 05. Canvas Items Group: TIP Implementation Status: Open Resolution: None Priority: 8 Private: No Submitted By: Donal K. Fellows (dkf) Assigned to: Jeffrey Hobbs (hobbs) Summary: TIP#119: Rotated text for canvas Initial Comment: This patch is a partial implementation of TIP#119, being for UNIX/X11 only. Needs Windows and OSX/Aqua implementations. Thanks to Simon Geard for recovering the patch (which had been lost) and upgrading it to work with 8.5. :-) Includes copy of xvertext 5.0; I think the license is Tcl/Tk-compatible. ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2008-11-05 15:01 Message: D'oh! Had the order of transforms wrong. Rotated text on OSX now works with the new patch. File Added: rotate.patch ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2008-11-05 14:46 Message: Here's a *highly buggy* version of the rotated text renderer for OSX. No idea what's wrong. File Added: rotate_mac.patch ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2008-11-04 01:21 Message: Adding a partial implementation with some good features over the original. 1) Not disruptive of any public API. 2) Uses Xft for doing rotated text. 3) Does the bounding box properly; animated rotating text works. 4) Handles the text item's -underline option. Still to do: 1) Adaptations for other renderers (should be easy for OSX and Win). 2) Handle highlighting, the cursor and the caret. File Added: rotate.patch ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2007-10-30 19:51 Message: Logged In: YES user_id=72656 Originator: NO See also 220784 for old patch ---------------------------------------------------------------------- Comment By: Daniel A. Steffen (das) Date: 2006-12-12 07:00 Message: Logged In: YES user_id=90580 Originator: NO a few comments from a quick read through the patch: - contains two copies of rotated.c and rotated.h in unix and xlib, if the right place for these is unix/ they should be renamed to conform to the tkUnix* pattern. - tkUnixPort.h includes rotated.h with a relative path which will not work in an install location. - three routines in the public stubs table are changed to take an additional angle param, this incompatibility is not discussed in the TIP, it might be better to introduce additional API that the originals call through. - changes tkDecls.h directly instead of tk.decls - tkCanvText.c contains leftover printf debugging and commented out bits - no tests or docs, testscript added to unix/ The aqua implementation should be easy, all that should be required is to setup a rotation CTM before the ATSUI quartz text drawing. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1611359&group_id=12997 |