[Tcl-bugs] [ tktoolkit-Patches-1997907 ] tk::busy command

[SourceForge.net <no...@so...>]

Patches item #1997907, was opened at 2008-06-19 16:32
Message generated for change (Comment added) made by decosterjos
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1997907&group_id=12997

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 56. [grab]
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Decoster Jos (decosterjos)
Assigned to: Jeffrey Hobbs (hobbs)
Summary: tk::busy command

Initial Comment:
Hi,

After some discussions on #tcl, I started adding the BLT busy command to Tk as tk::busy. I've tried to convert as much as possible to the Tcl Object interface. Before writing a TIP I would like to get some feedback as this is my first try at writing a Tk core command.

Attached the patch created with command

  % cvs -q diff -wuN > busypatch.txt

based on the head revision.

Also attached a summary of the commands.

What's left to be done:

- man page
- tests for Tk test suite
- Mac version?

Jos.

----------------------------------------------------------------------

>Comment By: Decoster Jos (decosterjos)
Date: 2008-09-22 14:55

Message:
File Added: tkBusy.c

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-09-22 14:55

Message:
File Added: busypatch-06.txt

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-09-22 10:24

Message:
File Added: busy.n

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-09-22 10:24

Message:
File Added: busy.test

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-09-22 10:23

Message:
Renamed command to 'tk busy', Updated patch, man page and test suite.
File Added: busypatch-05.txt

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-09-11 09:09

Message:
File Added: busy.test

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-09-11 09:08

Message:
File Added: busy.n

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-09-11 09:08

Message:
File Added: busypatch-04.txt

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-06-30 14:04

Message:
Logged In: YES 
user_id=370749
Originator: YES

Tests for the tk::bsy command.
File Added: busy.test

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-06-30 14:03

Message:
Logged In: YES 
user_id=370749
Originator: YES

Updated man page.
File Added: busy.n

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-06-30 14:03

Message:
Logged In: YES 
user_id=370749
Originator: YES

A updated patch.
File Added: busypatch-03.txt

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-06-30 10:13

Message:
Logged In: YES 
user_id=370749
Originator: YES

A man page for the tk::busy command. The grab man page might get a 'see
also' pointing to tk::busy:

.SH "SEE ALSO"
busy(n)


Jos.
File Added: busy.n

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-06-26 09:19

Message:
Logged In: YES 
user_id=370749
Originator: YES

Updated the patch with suggested changes.
File Added: busypatch-02.txt

----------------------------------------------------------------------

Comment By: Donal K. Fellows (dkf)
Date: 2008-06-19 17:05

Message:
Logged In: YES 
user_id=79902
Originator: NO

Initial comments:

I see a number of sections of code where it's "#ifdef WIN32"-heavy. It'd
be better to factor those pieces out into platform-specific implementations
of Tkp functions (e.g. TkpMakeTransparentWindow for parts of the guts of
MakeTransparentWindowExist).

You can remove the debugging #ifdefs :-)

Why is the busy hash table (in tk.h/tkInt.h) part way through the
structure? That just causes gratuitous ABI incompatibility. Put it at the
end of the structure instead.

----------------------------------------------------------------------

Comment By: Decoster Jos (decosterjos)
Date: 2008-06-19 16:33

Message:
Logged In: YES 
user_id=370749
Originator: YES

File Added: busycmd.txt

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1997907&group_id=12997