Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Patches-1539990 ] Improve speed of Tk_PhotoPutBlock for one-row case
|
From: SourceForge.net <no...@so...> - 2007-10-30 20:00:35
|
Patches item #1539990, was opened at 2006-08-14 06:38 Message generated for change (Comment added) made by hobbs You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1539990&group_id=12997 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 41. Photo Images Group: None Status: Open Resolution: None Priority: 6 Private: No Submitted By: Jeff Epler (jepler) Assigned to: Donal K. Fellows (dkf) Summary: Improve speed of Tk_PhotoPutBlock for one-row case Initial Comment: In my application, I use tkimg1.3 to load xpm images with transparency information. I compared the time taken to load the image in tk8.2+tkimg1.3 to the time taken in tk8.4+tkimg1.3: 8.2: 59086 microseconds 8.4: 769918 8.4, patched: 77059 This patch expands the 'single pixel' case into a 'single span' case: one or more pixels on a single row of the image, where all have alpha 0 or 255. (in fact, tkimg1.3's xpm loader always sends spans with fully opaque pixels) As you can see, this patch reduces the time from 13x as long as 8.2 to only 1.3x as long as 8.2. ---------------------------------------------------------------------- >Comment By: Jeffrey Hobbs (hobbs) Date: 2007-10-30 13:00 Message: Logged In: YES user_id=72656 Originator: NO See also 224066 ---------------------------------------------------------------------- Comment By: Jeff Epler (jepler) Date: 2007-02-01 05:57 Message: Logged In: YES user_id=2772 Originator: YES The "8.4" timings were done against tk 8.4.10. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2006-08-14 09:26 Message: Logged In: YES user_id=72656 If this was tested against 8.4.13, please test against 8.4.12 or the cvs head. 8.4.13 had a known slowdown case in Tk_PhotoPutBlock. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=312997&aid=1539990&group_id=12997 |