[Tcl-bugs] [ tcl-Bugs-1689286 ] nmakehlp not building on Win32 with VC

[SourceForge.net <no...@so...>]

Bugs item #1689286, was opened at 2007-03-27 08:09
Message generated for change (Settings changed) made by mdejong
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1689286&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 70. Sample Extension
Group: development: 8.5a6
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Twylite (twylite)
>Assigned to: David Gravereaux (davygrvy)
Summary: nmakehlp not building on Win32 with VC

Initial Comment:

I have just got the latest sampleextension from CVS, and am getting errors building it with VC6 or VC8.

  c:\build\sampleextension\win> pushd sampleextension\win
  c:\build\sampleextension\win> nmake /f makefile.vc all TCLDIR=..\..\tcl TKDIR=..\..\tk
  'nmakehlp' is not recognized as an internal or external command,
  operable program or batch file.
  ...<snip>
  Command line warning D4002 : ignoring unknown option '-fp:strict'
  Command line warning D4002 : ignoring unknown option '-GS'
  Command line warning D4002 : ignoring unknown option '-GL'
  ...<snip>
  LINK : warning LNK4044: unrecognized option "ltcg"; ignored

The problems aren't fatal, but they shouldn't be there.

Nmakehlp.exe doesn't build because:

  c:\sampleextension\win> cl nmakehlp.c
  ...<snip>
  /out:nmakehlp.exe
  nmakehlp.obj
  nmakehlp.obj : error LNK2001: unresolved external symbol _wnsprintf
  nmakehlp.exe : fatal error LNK1120: 1 unresolved externals
  
This can be solved by taking the latest nmakehlp.c from the Tcl sources:

  c:\sampleextension\win> copy ..\..\tcl\win\nmakehlp.c
  
The other warnings are fixed as a result of successfully building and using nmakehlp.

--

The next problem is that running the tests doesn't work.  The makefile looks for tclsh85.exe, which doesn't exist since I'm using a threaded build of Tcl.  

The problem is on line 298 of rules.vc:

  SUFX	    = sgx

should be

  SUFX	    = tsgx
  
since the sampleextension build is supposed to be threaded by default.

--

Patch file against CVS is attached:
- Updates nmakehlp.c to match the tcl module's version
- Add 't' flag to SUFX default




----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1689286&group_id=10894