[Tcl-bugs] [ tcl-Bugs-1569064 ] different ~ expansions in [file] causes fCmd 6.26 to fail

[SourceForge.net <no...@so...>]

Bugs item #1569064, was opened at 2006-10-01 22:27
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1569064&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 36. File System
Group: current: 8.5a4
Status: Open
Resolution: None
Priority: 5
Submitted By: WL (wliao)
Assigned to: Vince Darley (vincentdarley)
Summary: different ~ expansions in [file] causes fCmd 6.26 to fail

Initial Comment:
The fCmd-6.26 test uses [file dirname ~] and [file tail
~] to construct the test message. This acts like [file
normalize] in expanding the ~ and any symbolic links.
However, the error message from [file copy] behaves like
[file nativename]: the ~ is expanded, but it doesn't seem
to follow the symbolic links. The test on a machine with
symbolic links in ~ will fail like this

  ---- Result was:
  1 {error copying "~/td1" to "td1":
"/home/wl/td1/td2": permission denied}
  ---- Result should have been (exact matching):
  1 {error copying "~/td1" to "td1":
"/d1/home/wl/td1/td2": permission denied}

The error message of [file copy] can be changed, which is
probably a bad idea, or a minor change be made to the test
by wrapping the ~ with [file natiename]:

  tests$ diff fCmd.test fCmd.test.orig
  584c584
  < } "1 {error copying \"~/td1\" to \"td1\": \"[file
join [file dirname [file nativename ~]] [file tail
[file nativename ~]] td1 td2]\": permission denied}"
  ---
  > } "1 {error copying \"~/td1\" to \"td1\": \"[file
join [file dirname ~] [file tail ~] td1 td2]\":
permission denied}" 


----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2006-10-12 12:06

Message:
Logged In: NO 

Hmm,

Well it's SetFsPathFromAny that does the '~ = TclGetEnv("HOME",...)', so 
something interesting must happen after that point. It's certainly not clear to me 
why there would be a difference in behaviour (particularly one that stems back 
to 8.4.0 -- I could imagine that some of the 'cleverer' code added since then 
might have caused some change here, but 8.4.0 was relatively simple from an FS 
point of view).

Vince.


----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2006-10-12 11:21

Message:
Logged In: YES 
user_id=80530


This appears to be an
8.3 -> 8.4 change (regression?)
in ~ expansion.

On a similar machine configuration
I have access to:

% info patchlevel
8.3.5
% file dirname ~
/users
% file dirname /users/dgp
/users

% info patchlevel
8.4.0
% file dirname ~
/site/users
% file dirname /users/dgp
/users

Vince can you comment?


----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2006-10-12 10:48

Message:
Logged In: YES 
user_id=80530


I'd like to understand the history
better before accepting this change.

That technique for constructing
the expected test result dates all
the way back to 1998.  Has this test
always failed under these circumstances,
or are we see some recent regression
exposed?


----------------------------------------------------------------------

Comment By: WL (wliao)
Date: 2006-10-04 11:54

Message:
Logged In: YES 
user_id=863965

It seems this is the same behavior in 8.4.14:

  ---- Result was:
  1 {error copying "~/td1" to "td1": "/home/wl/td1/td2": 
permission denied}
  ---- Result should have been (exact matching):
  1 {error copying "~/td1" to "td1": "/d1/home/wl/td1/td2":
permission denied}
  ==== fCmd-6.26 FAILED

Here is the output from with tcl (via tcltest):

  % puts $tcl_patchLevel
  8.4.14
  % puts [file normalize ~]; puts [file nativename ~]
  /d1/home/wl
  /home/wl


----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2006-10-04 10:28

Message:
Logged In: YES 
user_id=80530


Do you see the same problem
with 8.4.14 ?

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1569064&group_id=10894