From: SourceForge.net <no...@so...> - 2006-10-09 23:40:16
|
Bugs item #1574099, was opened at 2006-10-09 19:26 Message generated for change (Settings changed) made by msofer You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1574099&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 07. Variables Group: current: 8.5a4 >Status: Closed >Resolution: Fixed Priority: 5 Submitted By: miguel sofer (msofer) >Assigned to: miguel sofer (msofer) Summary: Tcl_UpVar(2)? and behaviour contrary to the docs Initial Comment: Ever since Tcl8.0, the documentation of Tcl_UpVar says about the flags: "Either TCL_GLOBAL_ONLY or 0; if non-zero, then destName is a global variable; otherwise it is a local to the current procedure (or global if no procedure is active)." Code comments, the procedure TestupvarCmd() and var-3.4 however say that TCL_NAMESPACE_ONLY is also accepted. A codesearch in google shows no users of any flag value other than 0 and TCL_GLOBAL_ONLY. Either the docs or the code requiring changing so that they agree. A priori, I would change the docs: even if unused, the ns-only flag value could be useful. OTOH, this is a *POTENTIAL INCOMPAT* - for anybody who would be relying on flags!=0 <=> flags==TCL_GLOBAL_ONLY Opinion? ---------------------------------------------------------------------- >Comment By: miguel sofer (msofer) Date: 2006-10-09 20:40 Message: Logged In: YES user_id=148712 Agreed - no real incompatibility, anybody relying on the docs would have found it already. ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2006-10-09 19:46 Message: Logged In: YES user_id=79902 If the implementation has been that way for ages, might as well document it. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=1574099&group_id=10894 |