[Tcl-bugs] [ tcl-Patches-1519940 ] Tcl_CreateObjCommand calls TclInvalidateNsPath twice

[SourceForge.net <no...@so...>]

Patches item #1519940, was opened at 2006-07-10 14:10
Message generated for change (Settings changed) made by dkf
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1519940&group_id=10894

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: 21. [namespace]
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Christoph Bauer (fridolin)
>Assigned to: Donal K. Fellows (dkf)
Summary: Tcl_CreateObjCommand calls TclInvalidateNsPath twice

Initial Comment:
Hi,

compare Tcl_CreateCommand and Tcl_CreateObjCommand.
The first call of  TclInvalidateNsPath()
seems to make no sense. There is a second call in the 
else-branch of if.

Christoph Bauer

1-liner patch:

*** tclBasic.c.orig     2006-07-10 15:04:18.000000000 
+0200
--- tclBasic.c  2006-07-10 15:03:53.000000000 +0200
***************
*** 1656,1662 ****
      }
  
      hPtr = Tcl_CreateHashEntry(&nsPtr->cmdTable, 
tail, &new);
-     TclInvalidateNsPath(nsPtr);
      if (!new) {
        cmdPtr = (Command *) Tcl_GetHashValue(hPtr);
  
--- 1656,1661 ----

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1519940&group_id=10894