[Tcl-bugs] [ tktoolkit-Bugs-1353022 ] Un-free'd Tcl_DString in win/tkWinDialog.c

[SourceForge.net <no...@so...>]

Bugs item #1353022, was opened at 2005-11-10 01:57
Message generated for change (Comment added) made by nobody
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112997&aid=1353022&group_id=12997

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Un-free'd Tcl_DString in win/tkWinDialog.c

Initial Comment:
1 In both FILE_INITFILE cases of both GetFileNameA 
and GetFileNameW, the ds Tcl_DString is not free'd.

(Since both functions are so similar, might be worth 
separating the common parts out into a single function.)


2. Also spotted:

line ~1964
 Tcl_TranslateFileName(..., &initDirString)
where the initDirString is then used without checking that
the function didn't return NULL ie. the DString is 
uninitialised. Not sure if this is a triggerable bug, but 
worth checking.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2005-11-10 02:52

Message:
Logged In: NO 

Did a quick grep and found some other un-free'd DString's
(None look like they'd ever overflow in practise)

tkTextWind.c ~852: Tcl_DString name

win/tkWinMenu.c ~3047: Tcl_DString boldItalicDString

tkBind.c ~2724: Tcl_DString cmd;



----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=112997&aid=1353022&group_id=12997