From: SourceForge.net <no...@so...> - 2005-08-24 20:18:22
|
Patches item #1267256, was opened at 2005-08-23 18:28 Message generated for change (Comment added) made by vasiljevic You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1267256&group_id=10894 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: 80. Thread Package Group: None Status: Open Resolution: Remind Priority: 5 Submitted By: Matt Newman (matt-newman) Assigned to: Zoran Vasiljevic (vasiljevic) Summary: enable static linking when TclX is present Initial Comment: When you statically link the thread extension w/ the TclX extension you get multiple defines - this patch addresses this issue in a minimal impact way. ---------------------------------------------------------------------- >Comment By: Zoran Vasiljevic (vasiljevic) Date: 2005-08-24 22:18 Message: Logged In: YES user_id=95086 I took pieces out the TclX for about 2 years ago. I will look into your changes and sync them in. Thanks for the hint. ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-08-24 19:25 Message: Logged In: YES user_id=72656 I don't know when tclXkeylist.c was forked, but I updated the TclX version with some mods that significantly improve performance on large keylists. You might also consider those when making changes. ---------------------------------------------------------------------- Comment By: Zoran Vasiljevic (vasiljevic) Date: 2005-08-24 15:17 Message: Logged In: YES user_id=95086 aha... ok. lets do those as well... ---------------------------------------------------------------------- Comment By: Matt Newman (matt-newman) Date: 2005-08-24 15:11 Message: Logged In: YES user_id=1333796 Thanks for making this change, however unfortunately I was not complete in the list of public symbols that class, the complete list - verified by using NM on the resultant objects is: #define tclXWrongArgs thread_tclXWrongArgs #define TclX_WrongArgs thread_TclX_WrongArgs #define TclX_AppendObjResult thread_TclX_AppendObjResult #define TclX_IsNullObj thread_TclX_IsNullObj #define TclX_KeyedListDelete thread_TclX_KeyedListDelete #define TclX_KeyedListGet thread_TclX_KeyedListGet #define TclX_KeyedListGetKeys thread_TclX_KeyedListGetKeys #define TclX_KeyedListInit thread_TclX_KeyedListInit #define TclX_KeyedListSet thread_TclX_KeyedListSet #define TclX_NewKeyedListObj thread_TclX_NewKeyedListObj ---------------------------------------------------------------------- Comment By: Zoran Vasiljevic (vasiljevic) Date: 2005-08-24 08:35 Message: Logged In: YES user_id=95086 Checked into CVS head branch. Instead of the proposed patch I made those symbols static in the tclXkeylist.c file. This should do. ---------------------------------------------------------------------- Comment By: Zoran Vasiljevic (vasiljevic) Date: 2005-08-23 21:07 Message: Logged In: YES user_id=95086 Thanks for the update. I will rather declare those as static in the tclXkeylist.c because those are only used from within that file. I will checkin the fix tomorrow in the cvs head branch. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1267256&group_id=10894 |