From: SourceForge.net <no...@so...> - 2005-04-06 00:25:27
|
Patches item #1175180, was opened at 2005-04-02 03:57 Message generated for change (Comment added) made by dkf You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1175180&group_id=10894 Category: None Group: None Status: Open Resolution: None Priority: 5 Submitted By: Don Porter (dgp) Assigned to: Don Porter (dgp) Summary: disable interp->result access support Initial Comment: Attached patch disables all code that supports the legacy interp->result field. To restore it, compile with USE_DIRECT_INTERP_RESULT_ACCESS defined. ---------------------------------------------------------------------- >Comment By: Donal K. Fellows (dkf) Date: 2005-04-06 01:25 Message: Logged In: YES user_id=79902 I worry about old (broken) code that accesses that field directly. OK, it's broken, but I don't want to be the one explaining that to users who find that their code no longer compiles because of poorly written code that happens to not be called. (That's quite possible with error handling code). OTOH, I was planning to do this (or rather a total purge) very early in the 9.0 cycle. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-04-04 21:03 Message: Logged In: YES user_id=80530 correct. no fields are removed by the patch. (though public access to them is). ---------------------------------------------------------------------- Comment By: Jeffrey Hobbs (hobbs) Date: 2005-04-04 21:01 Message: Logged In: YES user_id=72656 Without looking at the patch, I assume that this was done without changing the size of the Tcl_Interp structure, which would cause ABI issues. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-04-04 18:53 Message: Logged In: YES user_id=80530 Second patch goes beyond disabling to completely removing support for interp->result access. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2005-04-04 18:26 Message: Logged In: YES user_id=80530 Patch updated to include headers and tests. (Thanks jenglish!) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=310894&aid=1175180&group_id=10894 |