Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Bugs-1098779 ] TkParsePadAmount does not properly handle lists
|
From: SourceForge.net <no...@so...> - 2005-01-09 17:43:23
|
Bugs item #1098779, was opened at 2005-01-08 23:16 Message generated for change (Comment added) made by chengyemao You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=1098779&group_id=12997 Category: 48. Geometry Management Group: None Status: Open Resolution: None Priority: 5 Submitted By: Michael Kirkham (muonics) Assigned to: Chengye Mao (chengyemao) Summary: TkParsePadAmount does not properly handle lists Initial Comment: TkParsePadAmount manually parses through -padx/-pady values as a string, and fails to properly handle whitespace in the process, rather than treating the argument as a list object. This results in 'bad screen distance ""' errors if you do e.g.: pack $w -pady { 5 0 } ...or... pack $w -pady [list 5 0] ...instead of... pack $w -pady {5 0} Attached is a patch to correct the problem versus head, which should also be safe for 8.4 (TkParsePadAmount is the same in the two branches). ---------------------------------------------------------------------- >Comment By: Chengye Mao (chengyemao) Date: 2005-01-09 11:43 Message: Logged In: YES user_id=191079 The bug was due to fail to handle the leading spaces. To avoid converting the input string to a list, I only fix the bug by adding code to pass the leading spaces at the beginning. The patch works fine but requires converting the input string to a list first. It may be less efficient than processing the input string directly. However, if this is not the case, then the patch should be used. ---------------------------------------------------------------------- Comment By: Michael Kirkham (muonics) Date: 2005-01-08 23:24 Message: Logged In: YES user_id=498198 [list 5 0] may actually be okay, but { 5 0 } definitely is not. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=1098779&group_id=12997 |