Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Bugs-874745 ] cvs doesn't compile on macosx
|
From: SourceForge.net <no...@so...> - 2004-01-31 20:29:49
|
Bugs item #874745, was opened at 2004-01-10 19:41 Message generated for change (Comment added) made by jenglish You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=874745&group_id=12997 Category: 18. [text] Group: develop: 8.5a0 Status: Open Resolution: Remind Priority: 5 Submitted By: Francisco Leon (espectro) Assigned to: Vince Darley (vincentdarley) Summary: cvs doesn't compile on macosx Initial Comment: DynamicLibrary /Users/espectro/tk/macosx/../../build/tk/ Tk.framework/Versions/8.5/Tk DynamicLibrary.LinkUsingFileList /Users/espectro/tk/macosx/ ../../build/tk/Tk.framework/Versions/8.5/Tk /usr/bin/gcc-3.3 -o /Users/espectro/tk/macosx/../../ build/tk/Tk.framework/Versions/8.5/Tk "-L/Users/espectro/ tk/macosx/../../build/tk" "-F/Users/espectro/tk/macosx/../ ../build/tk" "-F/Users/espectro/tk/macosx/../../build/tcl" -filelist /Users/espectro/tk/macosx/../../build/tk/ Development.build/Wish.build/TkLibrary.build/Objects- normal/LinkFileList "-framework" "Tcl" "-framework" "Carbon" "-framework" "ApplicationServices" "-arch" "ppc" "-prebind" "-Wl,-single_module" "-dynamiclib" "- compatibility_version" "8.5" "-current_version" "8.5" "- seg1addr" "0xb000000" "-prebind" -install_name "`echo "/ Library/Frameworks/Tk.framework/Versions/8.5/Tk" | /usr/ bin/sed 's!//*!/!g'`" ld: warning prebinding disabled because of undefined symbols ld: Undefined symbols: _TclUtfToUniChar /usr/bin/libtool: internal link edit command failed ...failed DynamicLibrary.LinkUsingFileList /Users/espectro/tk/ macosx/../../build/tk/Tk.framework/Versions/8.5/Tk ... ** BUILD FAILED ** make: *** [develop] Error 1 8.4.5 compiles fine Using OSX Panther BTW, pbxbuild doesn't exist anymore. It's xcodebuild now ---------------------------------------------------------------------- >Comment By: Joe English (jenglish) Date: 2004-01-31 12:29 Message: Logged In: YES user_id=68433 Just removed "#include <tclInt.h>" from tkUnixPort.h and only got the following warnings: tkUnixEvent.c: In function `TkUnixDoOneXEvent': tkUnixEvent.c:473: warning: implicit declaration of function `TclpGetTime' tkUnixWm.c: In function `WaitForEvent': tkUnixWm.c:4428: warning: implicit declaration of function `TclpGetTime' These can be replaced with Tcl_GetTime() added by TIP #73 (done) ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2004-01-28 17:38 Message: Logged In: YES user_id=80530 I don't mind this as a temp fix in the HEAD. The HEAD should compile after all. :) Just didn't want to see this closed, and accept this as our "final answer". Yes, moving the #include of tclInt.h out of the tcl*Port.h files and into just those tcl*.c files that have internal access needs might give us a clearer picture of how much weaning is left to do. ---------------------------------------------------------------------- Comment By: Daniel A. Steffen (das) Date: 2004-01-28 17:30 Message: Logged In: YES user_id=90580 Donald, makes sense, should have looked into that, this was just the quickest fix to gets things linking again. To prevent such unilateral platform breakage in the future, maybe tclInt.h should be removed from tkUnixPort.h/ tkWinPort.h then ? ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2004-01-28 17:24 Message: Logged In: YES user_id=80530 Would be better to fix the broken code. We should be weaning Tk off of Tcl internals, not adding more uses of them. Re-open. ---------------------------------------------------------------------- Comment By: Daniel A. Steffen (das) Date: 2004-01-27 02:11 Message: Logged In: YES user_id=90580 This error is due to a missing '#include <tclInt.h>' in tk/generic/ tkTextIndex.c, as that file uses the TclUtfToUniChar macro from tclInt.h. The reason this works on other platforms is that they include tclInt.h in their tk*Port.h, but tkMacOSXPort.h doesn't (maybe it should?). Fix checked into HEAD & core-8-4-branch, c.f. diff below. As far as the missing pbxbuild on Panther goes, you can workaround this by saying 'make PBXBUILD=xcodebuild'; a fix to the Makefile that works on both Jaguar & Panther has been checked in. Index: generic/tkTextIndex.c ========================================= ========================== RCS file: /cvsroot/tktoolkit/tk/generic/tkTextIndex.c,v retrieving revision 1.15 diff -u -p -r1.15 tkTextIndex.c --- generic/tkTextIndex.c 13 Jan 2004 02:06:01 -0000 1.15 +++ generic/tkTextIndex.c 27 Jan 2004 10:06:33 -0000 @@ -17,6 +17,7 @@ #include "tkPort.h" #include "tkInt.h" #include "tkText.h" +#include <tclInt.h> /* * Index to use to select last character in line (very large integer): ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=874745&group_id=12997 |