Menu
▾
▴
[Tcl-bugs] [ tktoolkit-Bugs-833761 ] new test failures
|
From: SourceForge.net <no...@so...> - 2003-11-04 20:50:33
|
Bugs item #833761, was opened at 2003-10-31 17:32 Message generated for change (Comment added) made by vincentdarley You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=833761&group_id=12997 Category: 18. [text] Group: 8.5a0 Status: Open Resolution: None Priority: 7 Submitted By: Don Porter (dgp) >Assigned to: Don Porter (dgp) Summary: new test failures Initial Comment: Starting with today's HEAD, these tests fail on Solaris 9: ==== textDisp-13.7 TkTextSeeCmd procedure FAILED ==== Contents of test case: .t xview moveto 0 .t yview moveto 0 .t tag add sel 30.20 .t tag add sel 30.40 update .t see 30.50 set x [list [.t bbox 30.50]] .t see 30.39 lappend x [.t bbox 30.39] .t see 30.38 lappend x [.t bbox 30.38] .t see 30.20 lappend x [.t bbox 30.20] ---- Result was: {73 64 7 13} {3 64 7 13} {3 64 7 13} {73 64 7 13} ---- Result should have been (exact matching): {73 55 7 13} {3 55 7 13} {3 55 7 13} {73 55 7 13} ==== textDisp-13.7 FAILED ==== textDisp-13.8 TkTextSeeCmd procedure FAILED ==== Contents of test case: .t xview moveto 0 .t yview moveto 0 .t tag add sel 30.20 .t tag add sel 30.50 update .t see 30.50 set x [list [.t bbox 30.50]] .t see 30.60 lappend x [.t bbox 30.60] .t see 30.65 lappend x [.t bbox 30.65] .t see 30.90 lappend x [.t bbox 30.90] ---- Result was: {73 64 7 13} {136 64 7 13} {136 64 7 13} {73 64 7 13} ---- Result should have been (exact matching): {73 55 7 13} {136 55 7 13} {136 55 7 13} {73 55 7 13} ==== textDisp-13.8 FAILED ==== textDisp-13.9 TkTextSeeCmd procedure FAILED ==== Contents of test case: wm geom . [expr $width-2]x$height .t xview moveto 0 .t yview moveto 0 .t tag add sel 30.20 .t tag add sel 30.50 update .t see 30.50 set x [list [.t bbox 30.50]] .t see 30.60 lappend x [.t bbox 30.60] .t see 30.65 lappend x [.t bbox 30.65] .t see 30.90 lappend x [.t bbox 30.90] ---- Result was: {80 66 7 13} {136 66 7 13} {136 66 7 13} {80 66 7 13} ---- Result should have been (exact matching): {80 55 7 13} {136 55 7 13} {136 55 7 13} {80 55 7 13} ==== textDisp-13.9 FAILED ==== textDisp-16.16 TkTextYviewCmd procedure, "moveto" option FAILED ==== Contents of test case: .t yview moveto .754 .t index @0,0 ---- Result was: 151.60 ---- Result should have been (exact matching): 151.80 ==== textDisp-16.16 FAILED ==== textDisp-16.18 TkTextYviewCmd procedure, "moveto" roundoff FAILED ==== Contents of test case: catch {destroy .top1} toplevel .top1 wm geometry .top1 +0+0 text .top1.t -height 3 -width 4 -wrap none -setgrid 1 -padx 6 -spacing3 6 .top1.t insert end "1\n2\n3\n4\n5\n6" pack .top1.t update .top1.t yview moveto 0.3333 set result [.top1.t yview] destroy .top1 set result ---- Result was: 0.333333333333 0.833333333333 ---- Result should have been (exact matching): 0.333333 0.833333 ==== textDisp-16.18 FAILED ==== textDisp-16.28 TkTextYviewCmd procedure, "scroll" option, forward pages FAILED ==== Contents of test case: .t yview 98.0 update .t yview scroll 1 page .t index @0,0 ---- Result was: 102.0 ---- Result should have been (exact matching): 103.0 ==== textDisp-16.28 FAILED ==== textDisp-17.7 TkTextScanCmd procedure FAILED ==== Contents of test case: .t yview 10.0 .t xview moveto 0 .t xview scroll 20 units .t scan mark -10 60 .t scan dragto -5 65 .t index @0,0 set x [.t index @0,0] .t scan dragto 0 70 list $x [.t index @0,0] ---- Result was: 6.13 2.6 ---- Result should have been (exact matching): 7.13 3.6 ==== textDisp-17.7 FAILED ==== textDisp-17.10 TkTextScanCmd procedure, word wrapping FAILED ==== Contents of test case: .t yview 10.0 .t scan mark -10 60 .t scan dragto -5 65 set x [.t index @0,0] .t scan dragto 0 70 list $x [.t index @0,0] ---- Result was: 9.15 8.31 ---- Result should have been (exact matching): 9.31 8.47 ==== textDisp-17.10 FAILED ==== textDisp-19.12 GetYView procedure, partially visible last line FAILED ==== Contents of test case: catch {destroy .top} toplevel .top wm geometry .top +0+0 text .top.t -width 40 -height 5 pack .top.t -expand yes -fill both .top.t insert end "Line 1\nLine 2\nLine 3\nLine 4\nLine 5" # Need to wait for asychronous calculations to complete. update ; after 10 scan [wm geom .top] %dx%d twidth theight wm geom .top ${twidth}x[expr $theight - 3] update .top.t yview ---- Result was: 0.0 0.96 ---- Result should have been (exact matching): 0.0 0.9625 ==== textDisp-19.12 FAILED ==== textDisp-19.13 GetYView procedure, partially visible last line FAILED ==== Contents of test case: catch {destroy .top} toplevel .top wm geometry .top +0+0 text .top.t -width 40 -height 5 pack .top.t -expand yes -fill both .top.t insert end "Line 1\nLine 2\nLine 3\nLine 4 has enough text to wrap around at least once" update scan [wm geom .top] %dx%d twidth theight wm geom .top ${twidth}x[expr $theight - 3] update .top.t yview ---- Result was: 0.0 0.96 ---- Result should have been (exact matching): 0 0.942308 ==== textDisp-19.13 FAILED ==== textDisp-19.16 count -ypixels FAILED ==== Contents of test case: .t configure -wrap word .t delete 1.0 end .t insert 1.0 "Line 1" foreach i {2 3 4 5 6 7 8 9 10 11 12 13 14 15} { .t insert end "\nLine $i" } .t insert end "\nThis last line wraps around four " .t insert end "times with a bit left on the last line." # Need to update so everything is calculated. update set res {} lappend res [.t count -ypixels 1.0 end] [.t count -update -ypixels 1.0 end] [.t count -ypixels 15.0 16.0] [.t count -ypixels 15.0 "16.0 displaylineend +1c"] [.t count -ypixels 16.0 "16.0 displaylineend +1c"] [.t count -ypixels "16.0 +1 displaylines" "16.0 +4 displaylines +3c"] ---- Result was: 260 260 13 26 13 39 ---- Result should have been (exact matching): 300 300 15 30 15 45 ==== textDisp-19.16 FAILED ==== textDisp-20.2 FindDLine FAILED ==== Contents of test case: .t yview 100.0 .t yview -pickplace 53.0 list [.t dlineinfo 50.0] [.t dlineinfo 50.14] [.t dlineinfo 50.15] ---- Result was: {3 -1 105 13 10} {3 -1 105 13 10} {3 12 140 13 10} ---- Result should have been (exact matching): {} {} {3 3 140 13 10} ==== textDisp-20.2 FAILED ==== textDisp-29.1 miscellaneous: lines wrap but are still too long FAILED ==== Contents of test case: catch {destroy .t2} toplevel .t2 wm geometry .t2 +0+0 text .t2.t -width 20 -height 10 -font $fixedFont -wrap char -xscrollcommand ".t2.s set" pack .t2.t -side top scrollbar .t2.s -orient horizontal -command ".t2.t xview" pack .t2.s -side bottom -fill x .t2.t insert end 123 frame .t2.t.f -width 300 -height 50 -bd 2 -relief raised .t2.t window create 1.1 -window .t2.t.f update list [.t2.t xview] [winfo geom .t2.t.f] [.t2.t bbox 1.3] ---- Result was: {0.0 0.466666666667} 300x50+5+18 {12 68 7 13} ---- Result should have been (exact matching): {0 0.466667} 300x50+5+18 {12 68 7 13} ==== textDisp-29.1 FAILED ==== textDisp-29.2 miscellaneous: lines wrap but are still too long FAILED ==== Contents of test case: catch {destroy .t2} toplevel .t2 wm geometry .t2 +0+0 text .t2.t -width 20 -height 10 -font $fixedFont -wrap char -xscrollcommand ".t2.s set" pack .t2.t -side top scrollbar .t2.s -orient horizontal -command ".t2.t xview" pack .t2.s -side bottom -fill x .t2.t insert end 123 frame .t2.t.f -width 300 -height 50 -bd 2 -relief raised .t2.t window create 1.1 -window .t2.t.f .t2.t xview scroll 1 unit update list [.t2.t xview] [winfo geom .t2.t.f] [.t2.t bbox 1.3] ---- Result was: {0.0233333333333 0.49} 300x50+-2+18 {5 68 7 13} ---- Result should have been (exact matching): {0.0233333 0.49} 300x50+-2+18 {5 68 7 13} ==== textDisp-29.2 FAILED ==== textDisp-29.3 miscellaneous: lines wrap but are still too long FAILED ==== Contents of test case: catch {destroy .t2} toplevel .t2 wm geometry .t2 +0+0 text .t2.t -width 20 -height 10 -font $fixedFont -wrap char -xscrollcommand ".t2.s set" pack .t2.t -side top scrollbar .t2.s -orient horizontal -command ".t2.t xview" pack .t2.s -side bottom -fill x .t2.t insert end 123 frame .t2.t.f -width 300 -height 50 -bd 2 -relief raised .t2.t window create 1.1 -window .t2.t.f update .t2.t xview scroll 200 units update list [.t2.t xview] [winfo geom .t2.t.f] [.t2.t bbox 1.3] ---- Result was: {0.536666666667 1.0} 300x50+-156+18 {} ---- Result should have been (exact matching): {0.536667 1} 300x50+-156+18 {} ==== textDisp-29.3 FAILED ==== textDisp-31.1 line embedded window height update FAILED ==== Contents of test case: set res {} .t delete 1.0 end .t insert end "abcd\nefgh\nijkl\nmnop\nqrst\nuvwx\nyx" frame .t.f -background red -width 100 -height 100 .t window create 3.0 -window .t.f lappend res [.t count -update -ypixels 1.0 end] .t.f configure -height 10 lappend res [.t count -ypixels 1.0 end] lappend res [.t count -update -ypixels 1.0 end] set res ---- Result was: 178 178 91 ---- Result should have been (exact matching): 190 190 105 ==== textDisp-31.1 FAILED ==== textDisp-31.2 line update index shifting FAILED ==== Contents of test case: set res {} .t.f configure -height 100 update lappend res [.t count -update -ypixels 1.0 end] .t.f configure -height 10 .t insert 1.0 "abc\n" .t insert 1.0 "abc\n" lappend res [.t count -ypixels 1.0 end] lappend res [.t count -update -ypixels 1.0 end] .t.f configure -height 100 .t delete 1.0 3.0 lappend res [.t count -ypixels 1.0 end] lappend res [.t count -update -ypixels 1.0 end] set res ---- Result was: 178 204 117 91 178 ---- Result should have been (exact matching): 190 220 135 105 190 ==== textDisp-31.2 FAILED ==== textDisp-31.3 line update index shifting FAILED ==== Contents of test case: # Should do exactly the same as the above, as long # as we are correctly tagging the correct lines for # recalculation. The 'update' and 'delay' must be # long enough to ensure all asynchronous updates # have been performed. set res {} .t.f configure -height 100 update lappend res [.t count -update -ypixels 1.0 end] .t.f configure -height 10 .t insert 1.0 "abc\n" .t insert 1.0 "abc\n" lappend res [.t count -ypixels 1.0 end] update ; after 1000 ; update lappend res [.t count -ypixels 1.0 end] .t.f configure -height 100 .t delete 1.0 3.0 lappend res [.t count -ypixels 1.0 end] update ; after 1000 ; update lappend res [.t count -ypixels 1.0 end] set res ---- Result was: 178 204 117 91 178 ---- Result should have been (exact matching): 190 220 135 105 190 ==== textDisp-31.3 FAILED ==== textDisp-31.4 line embedded image height update FAILED ==== Contents of test case: set res {} image create photo textest -height 100 -width 10 .t delete 3.0 .t image create 3.0 -image textest update lappend res [.t count -update -ypixels 1.0 end] textest configure -height 10 lappend res [.t count -ypixels 1.0 end] lappend res [.t count -update -ypixels 1.0 end] set res ---- Result was: 178 178 91 ---- Result should have been (exact matching): 190 190 105 ==== textDisp-31.4 FAILED ==== textDisp-31.5 line update index shifting FAILED ==== Contents of test case: set res {} textest configure -height 100 update ; after 1000 ; update lappend res [.t count -update -ypixels 1.0 end] textest configure -height 10 .t insert 1.0 "abc\n" .t insert 1.0 "abc\n" lappend res [.t count -ypixels 1.0 end] lappend res [.t count -update -ypixels 1.0 end] textest configure -height 100 .t delete 1.0 3.0 lappend res [.t count -ypixels 1.0 end] lappend res [.t count -update -ypixels 1.0 end] set res ---- Result was: 178 204 117 91 178 ---- Result should have been (exact matching): 190 220 135 105 190 ==== textDisp-31.5 FAILED ==== textDisp-31.6 line update index shifting FAILED ==== Contents of test case: # Should do exactly the same as the above, as long # as we are correctly tagging the correct lines for # recalculation. The 'update' and 'delay' must be # long enough to ensure all asynchronous updates # have been performed. set res {} textest configure -height 100 update ; after 1000 ; update lappend res [.t count -update -ypixels 1.0 end] textest configure -height 10 .t insert 1.0 "abc\n" .t insert 1.0 "abc\n" lappend res [.t count -ypixels 1.0 end] update ; after 1000 ; update lappend res [.t count -ypixels 1.0 end] textest configure -height 100 .t delete 1.0 3.0 lappend res [.t count -ypixels 1.0 end] update ; after 1000 ; update lappend res [.t count -ypixels 1.0 end] set res ---- Result was: 178 204 117 91 178 ---- Result should have been (exact matching): 190 220 135 105 190 ==== textDisp-31.6 FAILED ==== textWind-10.4 EmbWinLayoutProc procedure, error in creating window FAILED ==== Contents of test case: .t delete 1.0 end .t insert 1.0 "Some sample text" .t window create 1.5 -create { frame .t.f frame .t.f.f -width 10 -height 20 -bg $color } set msg xyzzy update list $msg [.t bbox 1.5] [winfo exists .t.f.f] ---- Result was: {{window name "f" already exists in parent}} {40 11 0 0} 1 ---- Result should have been (exact matching): {{can't embed .t.f.f relative to .t}} {40 11 0 0} 1 ==== textWind-10.4 FAILED ==== textWind-10.6 EmbWinLayoutProc procedure, error in creating window FAILED ==== Contents of test case: .t delete 1.0 end .t insert 1.0 "Some sample text" .t window create 1.5 -create { toplevel .t2 -width 100 -height 150 wm geom .t2 +0+0 concat .t2 } set msg xyzzy update list $msg [.t bbox 1.5] ---- Result was: {{window name "t2" already exists in parent}} {40 11 0 0} ---- Result should have been (exact matching): {{can't embed .t2 relative to .t}} {40 11 0 0} ==== textWind-10.6 FAILED ---------------------------------------------------------------------- >Comment By: Vince Darley (vincentdarley) Date: 2003-11-04 20:50 Message: Logged In: YES user_id=32170 Oh that's an easy fix. Here's a textWind patch ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2003-11-04 20:32 Message: Logged In: YES user_id=80530 With that patch, only test textDisp-16.28 fails: ==== textDisp-16.28 TkTextYviewCmd procedure, "scroll" option, forward pages FAILED ==== Contents of test case: .t yview 98.0 update .t yview scroll 1 page set res [expr int([.t index @0,0])] if {$fixedDiff > 1} { incr res -1 } ---- Result was: ---- Result should have been (exact matching): 102 ==== textDisp-16.28 FAILED ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2003-11-04 20:12 Message: Logged In: YES user_id=32170 Attached patch which should, I think, fix all the textDisp.test problems. Please test. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2003-11-04 18:48 Message: Logged In: YES user_id=80530 looks like progress, but still many failed tests. Attaching the failed test results on Solaris 9. Also: % set fixedAscent [font metrics $fixedFont -ascent] 10 % set varAscent [font metrics $varFont -ascent] 12 % set bigAscent [font metrics $bigFont -ascent] 22 ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2003-11-04 10:02 Message: Logged In: YES user_id=32170 Assigned to dgp for next round of testing. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2003-11-03 16:16 Message: Logged In: YES user_id=32170 Did a bit more work on this and checked in a fairly large set of fixes for many of these problems. The rest should now be fine-tuning, I hope. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2003-11-03 12:22 Message: Logged In: YES user_id=32170 Please try the attached patch. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2003-11-03 10:32 Message: Logged In: YES user_id=32170 Can you also provide values for set fixedAscent [font metrics $fixedFont -ascent] set varAscent [font metrics $varFont -ascent] set bigAscent [font metrics $bigFont -ascent] please? It'll take me a few days to get a decent patch to fix this (as far as I can tell though, this is 100% a test suite problem now). ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2003-10-31 18:46 Message: Logged In: YES user_id=80530 On the Solaris 8 box: % set fixedFont {Courier -12} Courier -12 % set fixedHeight [font metrics $fixedFont -linespace] 13 % set fixedWidth [font measure $fixedFont m] 7 % % set varFont {Times -14} Times -14 % set varHeight [font metrics $varFont -linespace] 15 % set bigFont {Helvetica -24} Helvetica -24 % set bigHeight [font metrics $bigFont -linespace] 27 ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2003-10-31 18:42 Message: Logged In: YES user_id=80530 the problems on (64-bit) Alpha are due to an incorrect type for the variable "length" on line 6860 of tkTextDisp.c It is declared size_t, but it should be declared int (because that's what Tcl_GetStringFromObj needs) ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2003-10-31 18:28 Message: Logged In: YES user_id=32170 It would also be very helpful to have the results of this: set fixedFont {Courier -12} set fixedHeight [font metrics $fixedFont -linespace] set fixedWidth [font measure $fixedFont m] set varFont {Times -14} set varHeight [font metrics $varFont -linespace] set bigFont {Helvetica -24} set bigHeight [font metrics $bigFont -linespace] On any platform for which these tests fail. ---------------------------------------------------------------------- Comment By: Vince Darley (vincentdarley) Date: 2003-10-31 18:10 Message: Logged In: YES user_id=32170 I'll set about fixing these. Some are easy -- just constrained tests which weren't running on my platforms and which just need the test updating. Some of them are harder, and I'll have to work out how to get the 'fonts' constraint handled more generally. However, where I'll need help is your second list of linux/alpha tests. I don't understand why these fail at all. Could you please try to debug. They are all doing something weird in TextGetScrollInfoObj in tkTextDisp.c. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2003-10-31 17:41 Message: Logged In: YES user_id=80530 On Linux/Alpha there are a few more: ==== textDisp-16.22.1 TkTextYviewCmd procedure, "scroll" option, back pages FAIL ED ==== Contents of test case: list [catch {.t yview scroll -3 p} res] $res ---- Result was: 1 {bad argument "p": must be units, pages or pixels} ---- Result should have been (exact matching): 1 {ambiguous argument "p": must be units, pages or pixels} ==== textDisp-16.22.1 FAILED ==== textDisp-16.23 TkTextYviewCmd procedure, "scroll" option, back pages FAILED ==== Contents of test case: .t yview 50.0 update .t yview scroll -3 pa .t index @0,0 ---- Test generated error; Return code was: 1 ---- Return code should have been one of: 0 2 ---- errorInfo: bad argument "pa": must be units, pages or pixels while executing ".t yview scroll -3 pa" ("uplevel" body line 4) invoked from within "uplevel 1 $script" ---- errorCode: NONE ==== textDisp-16.23 FAILED ==== textDisp-16.24 TkTextYviewCmd procedure, "scroll" option, back pages FAILED ==== Contents of test case: .t yview 5.0 update .t yview scroll -3 pa .t index @0,0 ---- Test generated error; Return code was: 1 ---- Return code should have been one of: 0 2 ---- errorInfo: bad argument "pa": must be units, pages or pixels while executing ".t yview scroll -3 pa" ("uplevel" body line 4) invoked from within "uplevel 1 $script" ---- errorCode: NONE ==== textDisp-16.24 FAILED ==== textDisp-16.28 TkTextYviewCmd procedure, "scroll" option, forward pages FAI LED ==== Contents of test case: .t yview 98.0 update .t yview scroll 1 page .t index @0,0 ---- Test generated error; Return code was: 1 ---- Return code should have been one of: 0 2 ---- errorInfo: bad argument "page": must be units, pages or pixels while executing ".t yview scroll 1 page" ("uplevel" body line 4) invoked from within "uplevel 1 $script" ---- errorCode: NONE ==== textDisp-16.28 FAILED ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=112997&aid=833761&group_id=12997 |