From: <no...@so...> - 2002-07-31 20:34:03
|
Bugs item #554351, was opened at 2002-05-09 22:25 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=554351&group_id=10894 Category: 70. Sample Extension Group: None Status: Open Resolution: None Priority: 5 Submitted By: Don Porter (dgp) >Assigned to: Donal K. Fellows (dkf) Summary: Sample Extension not 64-bit Aware Initial Comment: OK, the main point of the sampleextension is the TEA config/build/install stuff, but the extension still ought to actually work. It does not work on 64-bit Linux/Alpha: $ make test TCL_LIBRARY=`echo /local/src/tcl/library` LD_LIBRARY_PATH=".:/local/src/tcl/unix:/home/dgp/alpha/linux/lib:/usr/local/lib:/usr/lib" LIBPATH=".:/local/src/tcl/unix:" SHLIB_PATH=".:/local/src/tcl/unix:" PATH=".:/local/src/tcl/unix:/home/dgp/alpha/linux/bin:/home/dgp/Tcl:/home/dgp/Perl:/home/dgp/bin:/home/dgp/bin:/usr/local/bin:/bin:/usr/bin:/sbin:/usr/sbin:/usr/bin/X11:/usr/openwin/bin:/usr/games:." TCLLIBPATH="." "/local/src/tcl/unix/tclsh" `echo ./tests/all.tcl` Tests running in interp: /local/src/tcl/unix/tclsh Tests running with pwd: /local/src/sampleextension Tests running in working dir: /local/src/sampleextension/tests Only sourcing test files that match: *.test Tests began at Thu May 09 22:24:44 EDT 2002 sample.test ==== sha-1.1 Use of -string operand FAILED ==== Contents of test case: set result [sha1 -string foo] ---- Result was: b0b801b1bf5f29352b10094e72d6842b9676a1f8 ---- Result should have been (exact matching): 0beec7b5ea3f0fdbc95d0dd47f3c5bc275da8a33 ==== sha-1.1 FAILED make: *** [test] Segmentation fault My guess is that there's an implicit assumption of 32-bit "registers". ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2002-07-31 16:32 Message: Logged In: YES user_id=80530 After commenting out the assert(), I get a [load]-able shared library; thus a valid pkgIndex.tcl file, and after installing a `make test` runs successfully with 0 failures. So, good 64-bit fix (modulo assert-removal), but new build/install issues discovered. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2002-07-31 16:26 Message: Logged In: YES user_id=80530 Problem 1: The shared library produced with an --enable-symbols configuration will not [load]. This means that generation of pkgIndex.tcl also fails -- silently. Neither is good. % load libsample0.4g.so couldn't load file "libsample0.4g.so": /local/src/sampleextension/libsample0.4g.so: undefined symbol: assert Same problem without --enable-symbols actually: % load libsample0.4.so couldn't load file "libsample0.4.so": /local/src/sampleextension/libsample0.4.so: undefined symbol: assert ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2002-07-27 01:34 Message: Logged In: YES user_id=80530 assigning to myself so I'll remember to test this when I get home ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2002-07-26 11:04 Message: Logged In: YES user_id=79902 Could someone try this possible fix? ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2002-06-25 10:27 Message: Logged In: YES user_id=79902 Well, it's already scared *me* off for a while! ;^) Perhaps if I was to start by working from the tcllib version! ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2002-06-25 10:17 Message: Logged In: YES user_id=80530 that's enough to scare me away. ---------------------------------------------------------------------- Comment By: Donal K. Fellows (dkf) Date: 2002-06-25 05:10 Message: Logged In: YES user_id=79902 Ooer! SHA1Transform (in sample.c) is absolutely not portable to 64-bit systems (it assumes that sizeof(long)==4*sizeof(char) and that sizeof(long[16])==sizeof(char[64]), neither of which is guaranteed to be true, and both of which could fail independently.) Maybe the rest of that file is better, but I somehow doubt it... Fixing this bug requires a hefty rewrite of that file, so I'm dropping the priority. ---------------------------------------------------------------------- Comment By: Don Porter (dgp) Date: 2002-06-21 12:58 Message: Logged In: YES user_id=80530 I'll try to look into this. ---------------------------------------------------------------------- Comment By: Mo DeJong (mdejong) Date: 2002-05-21 14:20 Message: Logged In: YES user_id=90858 I don't have access to a 64 bit system. Sending back to hobbs in the hope that he can find someone with a 64 bit system. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=110894&aid=554351&group_id=10894 |