[Tcl-bugs] [ tcl-Bugs-219362 ] Tcl_CreateTrace callback does not terminate command string c

[<no...@so...>]

Bugs item #219362, was opened at 2000-10-26 02:11
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110894&aid=219362&group_id=10894

Category: 43. Parsing and Eval
Group: = 8.3.1
Status: Open
Resolution: None
Priority: 5
Submitted By: Nobody/Anonymous (nobody)
Assigned to: miguel sofer (msofer)
Summary: Tcl_CreateTrace callback does not terminate command string c

Initial Comment:
OriginalBugID: 5900 Bug
Version: 8.3.1
SubmitDate: '2000-06-14'
LastModified: '2000-06-14'
Severity: MED
Status: UnAssn
Submitter: welch
ChangedBy: welch
OS: All
FixedDate: '2000-10-25'
ClosedDate: '2000-10-25'


You need to run TclX to see this bug, but the callback made via
Tcl_CreateTrace passes in a command argument that is no longer
null-terminated at the end of the command.  Instead you see the
rest of the script.  This probably occurred in the effort to
remove "null hammering".

To see, take this script:

proc someProc {} {}

cmdtrace on noeval
someProc
someProc
someProc
cmdtrace off

And run it from the command line with Tcl X:

./tcl trace.test
 1:  someProc\nsomeProc\nsomeProc\ncmdtrace off\n
 1:  someProc\nsomeProc\ncmdtrace off\n
 1:  someProc\ncmdtrace off\n
 1:  cmdtrace off\n

In this simple case, the string should terminate at the \n



This has been broken since 8.2, we think.  It would be nice to fix
for Tcl 8.3.2 and TclPro 1.4

----------------------------------------------------------------------

>Comment By: miguel sofer (msofer)
Date: 2002-03-27 16:21

Message:
Logged In: YES 
user_id=148712

Patch committed; how did I forget?

----------------------------------------------------------------------

Comment By: miguel sofer (msofer)
Date: 2001-12-10 19:16

Message:
Logged In: YES 
user_id=148712

David Knoll proposed a patch for this bug [Patch 403420].
The patch has been updated to current HEAD and is provided
here as 219362.patch

The comments in the original patch were:
"all we've done here is substitute a new and more accurate
string length value in lieu of 'bytesLeft'. 
parse.commentStart and parse.commentSize could probably also
be used to prevent any leading comments from being passed to
the tclTrace callback."

----------------------------------------------------------------------

Comment By: miguel sofer (msofer)
Date: 2001-05-21 19:40

Message:
Logged In: YES 
user_id=148712

Related patches: #403420 & #403430

----------------------------------------------------------------------

Comment By: Don Porter (dgp)
Date: 2001-01-26 14:59

Message:
Patch 103420 has been proposed as a fix for this bug.

----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=110894&aid=219362&group_id=10894