[Tcl-bugs] [ tktoolkit-Patches-468139 ] Improved tk_chooseDirectory on Windows

[<no...@so...>]

Patches item #468139, was opened at 2001-10-04 18:32
You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=312997&aid=468139&group_id=12997

Category: 34. [tk_chooseDirectory]
Group: None
Status: Open
Resolution: None
Priority: 5
Submitted By: Tom Wilkason (wilkason)
Assigned to: Jeffrey Hobbs (hobbs)
Summary: Improved tk_chooseDirectory on Windows

Initial Comment:
The tk_chooseDirectory in the current and past Tk 
versions on windows uses the built-in windows 3.1 
style directory browse. This browser has many 
shortcomings including inability to select network 
shares via UNC names, returns all names in uppercase 
and generaly appears klunky and outdated. The attached 
patch, when applied to the latest Tk 1.21 
tkWinDialog.c will add the newer windows directory 
browser. You can still go back to the old version by 
#defining USE_OLD_CHOOSEDIR. Hopefully, if test goes 
well the code for the old browser can later be removed.
Worked based on initial Jeff Hobbs code and modified 
by Tom Wilkason (tom...@ho...).

----------------------------------------------------------------------

>Comment By: Jeffrey Hobbs (hobbs)
Date: 2001-11-17 15:01

Message:
Logged In: YES 
user_id=72656

attached is the full changes needed to the current 8.4a4 
setup for this (makefile changes too), although the 
aforementioned problems still need resolution.

----------------------------------------------------------------------

Comment By: Jeffrey Hobbs (hobbs)
Date: 2001-11-17 14:58

Message:
Logged In: YES 
user_id=72656

when running the modified file through the test suite, it 
did seem to return an extra '0' in winDialog.test-9.7.  
Also, you can't just type in a dirname in the entry widget 
and hit return - it always returns the empty string then 
(even if you expressly hit OK).

----------------------------------------------------------------------

Comment By: Tom Wilkason (wilkason)
Date: 2001-10-05 16:37

Message:
Logged In: YES 
user_id=95266

I don't see this problem. Since you didn't describe your 
test I can only guess that the interp result was not reset 
properly before the call. If you have the ability, please 
try and insert a Tcl_ResetResult(interp) near the beginning 
of the Tk_ChooseDirectoryObjCmd command. I have attached a 
replacement CVS diff that does this. If this problem still 
occurs please try and provide an environment in which it 
does (os, test script ...).

----------------------------------------------------------------------

Comment By: Christopher Nelson (chris_nelson)
Date: 2001-10-05 11:41

Message:
Logged In: YES 
user_id=107514

We tried applying this patch to 8.4a3 and found that when the user hits cancel, it returns "0", not "".


----------------------------------------------------------------------

You can respond by visiting: 
http://sourceforge.net/tracker/?func=detail&atid=312997&aid=468139&group_id=12997