#4809 HEAD fails to compile with symbols enabled on windows

[Ashok P. Nadkarni]

fossil head from core.tcl.tk (as of Mar 12)

nmake -f makefile.vc OPTS=symbols

results in the error

C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1321) : warning C4761: integ
ral size mismatch in argument; conversion supplied
C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1321) : error C2220: warning
treated as error - no object file generated
C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1333) : warning C4761: integ
ral size mismatch in argument; conversion supplied
C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1347) : warning C4761: integ
ral size mismatch in argument; conversion supplied
C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1592) : warning C4761: integ
ral size mismatch in argument; conversion supplied
C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1606) : warning C4761: integ
ral size mismatch in argument; conversion supplied
C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1644) : warning C4761: integ
ral size mismatch in argument; conversion supplied
C:\src\tcl-tk\head\tcl\win\..\generic\tclAssembly.c(1669) : warning C4761: integ
ral size mismatch in argument; conversion supplied

Compilation stops because with symbols warnings are treated as errors.

/Ashok

[Kevin B KENNY]

Could you retest with the current HEAD? I think I see what's going on, but I can't seem to make it fail on my machine on VS2005, 2008 or 2010, in either a debug or release build, and even with #pragma warning(error: 4761)

I presume that you're on VS6 or VS2003? I no longer have access to either of those.

[Ashok P. Nadkarni]

Tried with latest fossil head and had no issues building with OPTS=symbols

Did you actually fix anything or do we chalk this up to random user error (I did try it in more than one directory though)

[Kevin B KENNY]

I changed the data type of the offending parameter. It was perfectly legal before I changed it, and none of my Visual Studio installations complained about it either way.

There was also a worse problem in tclTest.c that current Visual Studio didn't like, and I fixed that one in a drive-by patch.