Menu

#3775 wrong variables in compat/memcmp.c

obsolete: 8.4.15
open
3
2007-09-06
2007-09-02
mladenk
No

Unable to compile memcmp.c
i looked in source and i think that used
variables are wrong.

Discussion

  • mladenk

    mladenk - 2007-09-02

    memcmp.c patch

     
  • miguel sofer

    miguel sofer - 2007-09-02
    • labels: 310718 --> 52. Portability Support
    • summary: wrong variables in memcmp.c --> wrong variables in compat/memcmp.c
     
  • Donal K. Fellows

    • assigned_to: nobody --> mdejong
    • priority: 5 --> 8
    • milestone: --> obsolete: 8.4.15
     
  • miguel sofer

    miguel sofer - 2007-09-02
    • assigned_to: mdejong --> nobody
    • priority: 8 --> 5
     
  • miguel sofer

    miguel sofer - 2007-09-02

    Logged In: YES
    user_id=148712
    Originator: NO

    Could you please explain what "unable to compile" means? What platform are you on?

     
  • Donal K. Fellows

    • priority: 5 --> 8
    • assigned_to: nobody --> mdejong
     
  • Nobody/Anonymous

    Logged In: NO

    I have Fedora 7 with gcc-4.1.2-12 and was trying to compile LFS.
    Something went wrong and i opened compat/memcmp.c to see what.
    Can you just look at the code i think it is trivial.

    Thanks Mladen

     
  • miguel sofer

    miguel sofer - 2007-09-03

    Logged In: YES
    user_id=148712
    Originator: NO

    This is a duplicate of bug #1631017, which is reported as fixed in both HEAD and 8.4. The files on HEAD and core-8-4-branch differ: is there a reason for that?

    Assigning to dkf as he reported this fixed.

     
  • miguel sofer

    miguel sofer - 2007-09-03
    • assigned_to: mdejong --> dkf
     
  • Joe English

    Joe English - 2007-09-06

    Logged In: YES
    user_id=68433
    Originator: NO

    From comments in #1631017:

    | The real bug is that compat/memcmp.c is being used in the first place -
    | if the build system is trying to use this file at all, it indicates that
    | the configure script has failed to detect a working C compiler.

    Other reports indicate that this happens when trying to cross-compile.
    One proposed solution is to use AC_TRY_LINK instead of AC_TRY_RUN.
    (sorry, reference not handy, I just vaguely remember reading this somewhere).

     
  • Donal K. Fellows

    Logged In: YES
    user_id=79902
    Originator: NO

    Fixed the obvious fault in compat/memcmp.c; I won't try to think about the bugs relating to why that file exists or is used.

     
  • Donal K. Fellows

    • assigned_to: dkf --> jenglish
    • priority: 8 --> 3