#2980 tests fail with tclsh instead of `make test`

obsolete: 8.5a2
closed-invalid
5
2004-11-29
2004-11-27
Don Porter
No

If instead of `make test`, I run

$ ./tclsh ../tests/all.tcl

the following tests fail:

==== clock-34.28 clock scan, day FAILED
==== Contents of test case:

clock format [clock scan "Monday" -gmt true -base
946627200] -format {%b %d, %Y %H:%M:%S} -gmt true

---- Result was:
Jan 03, 2000 08:00:00
---- Result should have been (exact matching):
Jan 03, 2000 00:00:00
==== clock-34.28 FAILED

==== clock-44.1 regression test - time zone name
containing hyphen FAILED
==== Contents of test case:

clock format 1098466496 -format %H:%M:%S%z
-timezone US/East-Indiana

---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: time zone US/East-Indiana not found
while executing
"ConvertUTCToLocal $date[set date {}] $timezone"
invoked from within
"clock format 1098466496 -format %H:%M:%S%z -timezone
US/East-Indiana"
("uplevel" body line 2)
invoked from within
"uplevel 1 $script"
---- errorCode: CLOCK badTimeZone {$:fileName}
==== clock-44.1 FAILED

the real error is probably in either the
tests, or in something about initialization.

Discussion

  • Kevin B KENNY

    Kevin B KENNY - 2004-11-29
    • assigned_to: kennykb --> dgp
     
  • Kevin B KENNY

    Kevin B KENNY - 2004-11-29

    Logged In: YES
    user_id=99768

    The real culprit here appears to be that the sequence
    you're using to run the test is finding an *installed*
    clock.tcl that doesn't have fixes for these bugs. If you
    just do
    ./tclsh ../tests/all.tcl
    you don't get TCL_LIBRARY assigned, and it finds clock.tcl
    in [file join $::tcl_library clock.tcl].

    Does it still fail if you do
    make SCRIPT="../tests/clock.tcl" shell
    instead of just running ./tclsh?

     
  • Don Porter

    Don Porter - 2004-11-29

    Logged In: YES
    user_id=80530

    thanks. that observation pointed
    me to my pilot error.

     
  • Don Porter

    Don Porter - 2004-11-29
    • status: open --> closed-invalid