Menu

#2756 new iogt.test failures

obsolete: 8.5a2
closed-fixed
8
2004-06-01
2004-06-01
Don Porter
No

==== iogt-2.1 basic I/O, operation trail FAILED
==== Contents of test case:

set fin [open $path(dummy) r]
set fout [open $path(dummyout) w]

set ain [list] ; set aout [list]
audit_ops ain -attach $fin
audit_ops aout -attach $fout

fconfigure $fin -buffersize 10
fconfigure $fout -buffersize 5

fcopy $fin $fout

close $fin
close $fout

set res "[join $ain \n]\n--------\n[join $aout \n]"

---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: bad value for -buffersize: must not be
less than 10 or greater than 1Mbyte.
while executing
"fconfigure $fout -buffersize 5"
("uplevel" body line 10)
invoked from within
"uplevel 1 $script"
---- errorCode: NONE
==== iogt-2.1 FAILED

==== iogt-2.2 basic I/O, data trail FAILED
==== Contents of test case:

set fin [open $path(dummy) r]
set fout [open $path(dummyout) w]

set ain [list] ; set aout [list]
audit_flow ain -attach $fin
audit_flow aout -attach $fout

fconfigure $fin -buffersize 10
fconfigure $fout -buffersize 5

fcopy $fin $fout

close $fin
close $fout

set res "[join $ain \n]\n--------\n[join $aout \n]"

---- Test generated error; Return code was: 1
---- Return code should have been one of: 0 2
---- errorInfo: bad value for -buffersize: must not be
less than 10 or greater than 1Mbyte.
while executing
"fconfigure $fout -buffersize 5"
("uplevel" body line 10)
invoked from within
"uplevel 1 $script"
---- errorCode: NONE
==== iogt-2.2 FAILED

Discussion

  • Andreas Kupries

    Andreas Kupries - 2004-06-01

    Logged In: YES
    user_id=75003

    Reassigned to david, this seems to originate in his latest
    changes.

     
  • Andreas Kupries

    Andreas Kupries - 2004-06-01
    • priority: 5 --> 8
    • assigned_to: andreas_kupries --> davygrvy
     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    Those buffersizes are invalid. I'll fix the test suite.

     
  • Don Porter

    Don Porter - 2004-06-01

    Logged In: YES
    user_id=80530

    I'd still like to see the change
    reverted. Who knows how many
    scripts depend on silent truncation
    of buffersize requests outside
    the valid range?

     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    depending on silent behavior is a dangerous dependancy.

    Try this, then scratch your head why:
    fconfigure stdout -buffersize 0x400

     
  • Don Porter

    Don Porter - 2004-06-01

    Logged In: YES
    user_id=80530

    Ah, I see. I'm fine with the
    conversion to use Tcl_GetInt
    and the error reporting when
    a non-integer value is provided.

    I'm opposed to the removal
    of silent range truncation only.
    That would take care of the tests,
    and any semi-sensible scripts.

    I don't want to add hard errors
    on buffersizes outside the limits
    mostly because it's not clear to
    me why the limits are imposed
    in the first place. I'd rather not
    enshrine them.

     
  • Don Porter

    Don Porter - 2004-06-01

    Logged In: YES
    user_id=80530

    see RFE 558932

     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    I'll pull-out the range verification, and revert the test suite
    mods I just did, but leave the Tcl_GetInt in place of atoi.

    The silent truncation still scares me.

     
  • David Gravereaux

    Logged In: YES
    user_id=7549

    test suite returned to "as before", failures fixed.

     
  • David Gravereaux

    • status: open --> closed-fixed
     
MongoDB Logo MongoDB