Menu

#10 stroke may not be insert at end of document

open
None
5
2003-12-01
2003-12-01
No

if the stroke insertion point is at the end of the
document, the pView::cmdInsertInk function seems to
insert ink beyond the EndOfDocument node in the piece
table. We need to make sure that if we attempt to
insert ink at the end of the document (beyond
text/enter marks) that we move the cursor to the last
valid spot OR insert all of the necessary text/blank lines.

this may requires some additional thought as it may
have profound effects on the user experience since they
may (probaby?) associate the ink strokes with the white
space at the end of the document rather than the
insertion point which appears just after all valid text in
the document.

would mean that when you start to type after the end
of a document where ink has been inserted that you end
up with ink overlapping text when you would have rather
had it insert white space and move the white space
down.

Discussion

  • Kevin Conroy

    Kevin Conroy - 2003-12-01

    Logged In: YES
    user_id=778951

    forgot to mention the failed assertion which brought this to
    my attention:

    File: pf_Fragments.cpp, Line 172
    Function: PF_Fragments::cleanFrags
    "UT_ASSERT(pfLast && (pfLast->getType() ==
    pf_Frag::PFT_EndOfDoc));"

    Runtime Values:
    pfLast->getType = PFT_Text (ink?)

     
  • Kevin Conroy

    Kevin Conroy - 2003-12-01
    • assigned_to: nobody --> kmconroy
     

Log in to post a comment.

MongoDB Logo MongoDB