Menu
▾
▴
[Synfig-devl] [ synfig-Bugs-2060732 ] Incorrect error message
|
From: SourceForge.net <no...@so...> - 2008-08-21 23:53:29
|
Bugs item #2060732, was opened at 2008-08-20 05:57 Message generated for change (Comment added) made by pabs3 You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757416&aid=2060732&group_id=144022 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Usability Group: SVN version Status: Open Resolution: None Priority: 5 Private: No Submitted By: Gerco Ballintijn (gballintijn) Assigned to: Gerco Ballintijn (gballintijn) Summary: Incorrect error message Initial Comment: When selecting the canvas and filename parameter in the parameters panel, an error message is printed on stderr. It reads "error: EXCEPTION: bad type: Bad type for curves". An examination of the code (src/gtkmm/widget_curves.cpp, lines 222 and 397), reveals however that nothing is wrong, and that this condition is subsequently ignored. The problem originate from the fact that neither filenames nor canvasses can be drawn as a curve, so they should be (and are) ignored by the curves widget. The method of ignoring them, i.e. the exception thrown and caught, results however also in the printing of an error message, and this is wrong. Attached is a patch that consistutes probably the easiest way to avoid this problem. Another solution would be to introduce a new exception, that doesn't also constitute an error, e.g. type_not_supported, or move the condition in the if-statement to the CurveStruct class, to enhance encapsulation. ---------------------------------------------------------------------- >Comment By: Paul Wise (pabs3) Date: 2008-08-22 07:53 Message: Logged In: YES user_id=35028 Originator: NO Patch looks good, apart from the unrelated change in the 3rd hunk (reformatting a catch statement). Please apply it to SVN, IIRC you should have access. In addition, please list yourself in the AUTHORS file. ---------------------------------------------------------------------- Comment By: Gerco Ballintijn (gballintijn) Date: 2008-08-21 03:31 Message: Logged In: YES user_id=2166902 Originator: YES Slightly improved version (more explicit) that uses a method call. File Added: patch.txt ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=757416&aid=2060732&group_id=144022 |