[Synfig-devl] [ synfig-Bugs-1357964 ] Missing get-methods in sphere_distort.h and stretch.h

[SourceForge.net <no...@so...>]

Bugs item #1357964, was opened at 2005-11-16 17:24
Message generated for change (Comment added) made by pabs3
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=1357964&group_id=144022

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
>Status: Closed
>Resolution: Fixed
Priority: 1
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Missing get-methods in sphere_distort.h and stretch.h

Initial Comment:
In src/module/lyr_std sphere_distort.cpp and
stretch.cpp some private members are called with
layer->center etc. Should have layer->get_center() and
the methods defined in sphere_distort.h and stretch.h .

----------------------------------------------------------------------

>Comment By: Paul Wise (pabs3)
Date: 2008-02-21 15:52

Message:
Logged In: YES 
user_id=35028
Originator: NO

Closing this bug because of dooglus' response.

----------------------------------------------------------------------

Comment By: dooglus (dooglus)
Date: 2007-09-16 05:41

Message:
Logged In: YES 
user_id=1546005
Originator: NO

These accesses of the 'center' member variable are legal, because:

class Layer_Stretch : public Layer {
	friend class ::Stretch_Trans;

and

class Layer_SphereDistort : public Layer_Composite {
	friend class Spherize_Trans;

so the member functions in the *_Trans classes are allowed to access
private member variables of the Layer_* classes.

If the accesses of the private members wasn't legal, the code wouldn't
compile, so I don't see the problem here.  Am I missing something?

----------------------------------------------------------------------

Comment By: Paul Wise (pabs3)
Date: 2006-02-19 18:12

Message:
Logged In: YES 
user_id=35028

Doesn't look fixed to me (SVN version 125).

----------------------------------------------------------------------

Comment By: Robert B. Quattlebaum, Jr. (darco)
Date: 2005-12-13 13:41

Message:
Logged In: YES 
user_id=206661

I believe this issue has been corrected.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=757416&aid=1357964&group_id=144022