#299 SkyPix: multiple rendering fixes + AREA FILL (command 3) implementation — patch, fonts, screenshots

[Gary McCulloch]

Testing SyncTERM against a live C-Net/Amiga SkyPix board Reign of Fire (telnet call.rofbbs.com 6800, press S at the prefs prompt) turned up several SkyPix issues. All six below are fixed/implemented in a single patch against src/syncterm. Full write-up, before/after screenshots, and the canonical Amiga fonts:

https://github.com/SpitfireTN/syncterm-skypix

Issue 1 SkyPix only worked if the graphics setting was RIPv3; added a dedicated "SkyPix" option.
Issue 2 Set-Font (ESC[10;size!name!) truncated at the first "!", leaking the font name as on-screen text.
Issue 3 fonts opened relative to CWD and SyncTERM ships no Amiga fonts; now resolved under the config dir (~/.config/syncterm/fonts/), with the canonical Amiga font set provided.
Issue 4 positioned text drew at the wrong place: pass-through text was batched while the pen moves applied inline, and SkyPix "!" terminators were being deferred.
Issue 5 backspace/line editing broke after a SkyPix screen (cterm->font_render left set on font reset).
Issue 6 AREA FILL (command 3) was an unimplemented TODO stub; implemented as a seed flood fill with a leak guard.

Known remaining: one non-deterministic rendering issue on a script-heavy screen (C-Net "ACIS" screen outline letters via ESC[2, flood fill via ESC[3, labels via ESC[19). Documented in the repo; it needs visible-pixel iteration.

Built from git rev 61a343a641 (local build "1.10i"), Linux x64 SDL2. Context/discussion: https://github.com/SpitfireTN/syncterm-skypix/issues/1 happy to test v2 builds against the live board.

Gary McCulloch ("SpitfireTN"), Reign of Fire BBS https://www.rofbbs.com

[Stephen James Hurd]

Thanks! SyncTERM v2 development is happening in a separate repo, you can clone it from https://gitlab.synchro.net/Deuce/syncterm.git or the github mirror at https://github.com/RealDeuce/SyncTERM.git

Landing pages for them are gitlab and github.

I expect to be pushing audio support (raw only, IFF doesn't seem to have been implemented anywhere) in a few minutes, not sure if RoF uses it. Once that's done, I'll take a look and see if I've already fixed these or not.

[Stephen James Hurd]

One thing I notice, your fonts are different than mine... the ones built in to SyncTERM came from a Workbench install I had I think, but your Ruby and Diamond fonts use different metrics. I'm auditing the metrics I have here, but I'm curious what the sources of the fonts in the repo are.

[Stephen James Hurd]

This is confirmed fixed in v2, and I slopped out a commit to v1.10b which should be in tonights build.

[Gary McCulloch]

Good eye on the fonts. The amiga-font/ set isn't custom - they're the stock
AmigaOS 2.0 "gem" fonts, $VER 37.1 (12.1.91) (Ruby/Diamond/Emerald/Pearl all
37.1, dated 12-Jan-1991), taken from a ClassicWB Workbench Fonts: drawer. I
grabbed those specifically because they're the same version my board's own
Amiga uses - I checked, and ruby12 37.1 (12.1.91), diamond12 37.1 (12.1.91),
etc. match byte-for-byte on both sides. So the repo set IS the exact metrics
Reign of Fire's screens assume - you can audit straight against amiga-font/.
If yours came from a different Workbench, that would be the Ruby/Diamond
difference; 37.1 is the 2.0 set and it's what RoF (and I'd bet most
C-Net/Amiga boards) renders against. The rgterm-spf/ set is separate - that's
RGTerm's own format, included only for reference; the Amiga .font set is the
one that matters for SyncTERM.

Thanks for the v2 repo - I'll clone the GitHub mirror (RealDeuce/SyncTERM),
build it, and run it against the board so I can tell you what's already fixed
vs not.

As for SkySound, that I plan on playing with soon.

[Stephen James Hurd]

Ah, I see what happened with the fonts... at some point, the LLM decided I needed to use the ones from IcyTerm for copyright reasons and I had to stop using the real ones. Fixing that now.

[Stephen James Hurd]

Also now, the 1.3 fonts are used in 1.3 mode and 2.x+ fonts are used in 3.1 mode.