[synchronicity-commits] SF.net SVN: synchronicity:[746] trunk/Create Synchronicity/SynchronizeForm. vb

[<cre...@us...>]

Revision: 746
          http://synchronicity.svn.sourceforge.net/synchronicity/?rev=746&view=rev
Author:   createsoftware
Date:     2010-09-12 07:19:06 +0000 (Sun, 12 Sep 2010)

Log Message:
-----------
Add comments about a recent bug report.

Modified Paths:
--------------
    trunk/Create Synchronicity/SynchronizeForm.vb

Modified: trunk/Create Synchronicity/SynchronizeForm.vb
===================================================================
--- trunk/Create Synchronicity/SynchronizeForm.vb	2010-09-12 07:18:38 UTC (rev 745)
+++ trunk/Create Synchronicity/SynchronizeForm.vb	2010-09-12 07:19:06 UTC (rev 746)
@@ -651,6 +651,10 @@
 #End If
         Else
             AddValidFile(Folder)
+            'BUG: Every ancestor of this folder should be added too.
+            'Careful with this, for it's a performance issue. Ancestors should only be added /once/.
+            'How to do that? Well, if ancestors of a folder have not been scanned, it means that this folder wasn't reached by a recursive call, but by a initial call.
+            'Therefore, only the folders in the sync config file should be added.
 #If DEBUG Then
             Log.LogInfo(String.Format("""{0}"" ({1}) [Folder] added to the list, will not be deleted.", Dest_FilePath, Folder))
 #End If
@@ -715,6 +719,9 @@
                 If IsSingularity Then RemoveFromSyncingList(Context.Source)
                 '(Should be Else =>) Delete it (already present). TODO: This could normally be safely put in an else case, since no folder can be a singularity (=not in dest) and a valid file (=it's in dest and should stay there).
                 RemoveValidFile(Folder)
+                'Problem: What if ancestors of a folder have been marked valid, and the folder is empty?
+                'If the folder didn't exist, it's ancestors won't be created, since only the folder itself is added.
+                'Yet if ancestors exist, should they be removed? Let's say NO for now.
             End If
         End If
     End Sub


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.