u-boot fails to build for br4 box in revision 670
Status: Beta
Brought to you by:
dpenev
Menu
▾
▴
#4 u-boot fails to build for br4 box in revision 670
During the build process, the system tries to download some files. I keep getting the following message:
wget --passive-ftp -nd -P /usr/src/switchfin/dl 'http://blackfin.uclinux.org/git/?p=u-boot;a=snapshot;h=dc1aeebd486bc0408902b96402cd6455cc93eb1a;sf=tgz'/u-boot-dc1aeeb.tar.gz
--2011-12-16 14:49:23-- http://blackfin.uclinux.org/git/?p=u-boot;a=snapshot;h=dc1aeebd486bc0408902b96402cd6455cc93eb1a;sf=tgz/u-boot-dc1aeeb.tar.gz
Resolving blackfin.uclinux.org... 66.11.68.51
Connecting to blackfin.uclinux.org|66.11.68.51|:80... connected.
HTTP request sent, awaiting response... 400 Bad Request
2011-12-16 14:49:25 ERROR 400: Bad Request.
When I go back to revision 660, everything is fine. I believe one of the uBoot changes (revisions 661, 662, 664 or 665 introduced the problem)
Fix ifeq SF_PR1_APPLIANCE/SF_BR4_APPLIANCE mixup
I had some time to dig into the issue and found a ifeq combination like this:
ifeq ($(strip $(SF_PR1_APPLIANCE)),y)
ifeq ($(strip $(SF_BR4_APPLIANCE)),y)
As it's not very likely that you'll build for PR1 and BR4 simultaneously, I unwound the construct so it should still do the same thing as before for PR1 and now works for BR4, too. I believe that other box types are possibly still broken, as the "else" branch still generates an invalid URI (appends the slash and stuff after the single quote).