#10 SSDataGrid::DefaultEditor::stopCellEditing missing return?

[Ernie Rael]

While browsing, I came across something suspicious. Seems like should be

return super.stopCellEditing

Maybe not a bug. Here's the context

        public boolean stopCellEditing() {
            String s = (String) super.getCellEditorValue();

            if (s.trim().equals("")) {
                if (this.constructor.getDeclaringClass() == String.class) {
                    this.value = s;
                }
                super.stopCellEditing();
            }

[Brian E. Pangburn]

Committed fix from Prasanth Pasala:

    @Override
    public boolean stopCellEditing() {

        String s = (String) super.getCellEditorValue();

        if (s.trim().equals("")) {
            if (this.constructor.getDeclaringClass() == String.class) {
                this.value = s;
            }
        } else {
            try {
                this.value = this.constructor.newInstance(new Object[] { s });
            } catch (Exception e) {
                // DRAW A RED BORDER IF THE VALUE OBJECT CAN'T BE CREATED.
                // PROBABLY THE DATA ENTERED IS NOT RIGHT (STRING IN NUMBER FIELD OR VICE-VERSA)
                ((JComponent) getComponent()).setBorder(new LineBorder(Color.red));
                return false;
            }
        }

        return super.stopCellEditing();

    }

[Ernie Rael]

I guess with the database being reponsible for white space handling (don't take my word for it, I'm just guessing)

this.value = s; // may have whitespace characters

is not that different from

this.value = "";