From: SourceForge.net <no...@so...> - 2007-09-17 20:50:37
|
Patches item #1796609, was opened at 2007-09-17 21:50 Message generated for change (Tracker Item Submitted) made by Item Submitter You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1796609&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Olly Betts (olly) Assigned to: William Fulton (wsfulton) Summary: [java] Eliminate allocation of a temp buffer Initial Comment: I noticed that a use of new[] and delete[] can be avoided in the code Java generates for std::wstring. I checked that "make check-test-suite" generates the same stdout and stderr before and after this patch (which is against revision 9936). Posting to the patch tracker rather than just applying in case I'm missing some subtlety - if you're busy William, I'm happy to apply this if you give the OK. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1796609&group_id=1645 |
From: SourceForge.net <no...@so...> - 2007-09-19 23:40:41
|
Patches item #1796609, was opened at 2007-09-17 20:50 Message generated for change (Comment added) made by wsfulton You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1796609&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Olly Betts (olly) Assigned to: William Fulton (wsfulton) Summary: [java] Eliminate allocation of a temp buffer Initial Comment: I noticed that a use of new[] and delete[] can be avoided in the code Java generates for std::wstring. I checked that "make check-test-suite" generates the same stdout and stderr before and after this patch (which is against revision 9936). Posting to the patch tracker rather than just applying in case I'm missing some subtlety - if you're busy William, I'm happy to apply this if you give the OK. ---------------------------------------------------------------------- >Comment By: William Fulton (wsfulton) Date: 2007-09-19 23:40 Message: Logged In: YES user_id=242951 Originator: NO Looks okay to me. Please commit and you could also apply the same change to the director typemaps in this file. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1796609&group_id=1645 |
From: SourceForge.net <no...@so...> - 2007-09-20 01:05:25
|
Patches item #1796609, was opened at 2007-09-17 21:50 Message generated for change (Comment added) made by olly You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1796609&group_id=1645 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Olly Betts (olly) Assigned to: William Fulton (wsfulton) Summary: [java] Eliminate allocation of a temp buffer Initial Comment: I noticed that a use of new[] and delete[] can be avoided in the code Java generates for std::wstring. I checked that "make check-test-suite" generates the same stdout and stderr before and after this patch (which is against revision 9936). Posting to the patch tracker rather than just applying in case I'm missing some subtlety - if you're busy William, I'm happy to apply this if you give the OK. ---------------------------------------------------------------------- >Comment By: Olly Betts (olly) Date: 2007-09-20 02:05 Message: Logged In: YES user_id=14972 Originator: YES OK, applied along with fixes for the other similar cases in the same file. ---------------------------------------------------------------------- Comment By: William Fulton (wsfulton) Date: 2007-09-20 00:40 Message: Logged In: YES user_id=242951 Originator: NO Looks okay to me. Please commit and you could also apply the same change to the director typemaps in this file. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=301645&aid=1796609&group_id=1645 |