[swanmodel-users] Documentation about number of cells around vertex and large angles in an unstructured grid

[João A. <ja...@au...>]

Hello,

I am trying to run SWAN with an unstructured grid generated by BlueKenue
software and I am having the problems that everybody that uses unstructured
grids have: large angles and less than 4 cells around an internal vertex.

While checking SwanCheckGrid's code to try to add more information about
these problematic triangles, such as which, how many, and where they are, I
noticed an inconsistency between the code, the code's comments and SWAN's
documentation.

According to the comments at the code, and SWAN's manual, "the number of
cells around vertex must be at least 4 and not larger than 10". However,
the code that checks the amount of vertices is:

do i = 1, nverts
       if ( vcount(i) > 0 .and. vcount(i) < 4 .and. vmark(i) == 0 )
badvertex = .true.
       if ( vcount(i) > 10 ) badvertex = .true.
enddo

So the '< 4' at if statement is currently testing if there are at least 5
cells instead of the 4 mentioned at the documentation.

Does anybody knows if this is an issue or if there is a reason for the code
to be testing at least 5 nodes instead of the 4? Should the code be fixed
to '<= 4' or the documentation updated?

Regards,

-- 
João Claudio Albuquerque
PhD. Candidate, School of Environment, The University of Auckland,
Level 4, Room 449, Science Centre, 23 Symonds Street, Auckland, NZ.
+64 021 02365705