Re: [Svxlink-devel] Metar 0.2
Brought to you by:
sm0svx
From: Tobias B. <sm...@us...> - 2009-11-23 21:05:31
|
On Monday 26 October 2009 16:40:31 Martin Burkhardt wrote: > Hi Tobias and Adi, > > > > Hi Tobias, > > > > > > enclosed the new Metarmodule. Martin (DF1AMB) is preparing the > > > mary-sounds, adapting tcl-files and conducting tests. I think it will > > > follow next time. Thank you for help, Martin. > > > > Great! > > > > I have checked your new module into Subversion. I'll also test it once > > you send me the audio generation text files. > > Finally I was able to fix the last few obvious things in MetarInfo text > files for audio creation. I have the MetarInfo directory attached to this > Email. OK. I have had a look at the MetarInfo module again now. I still don't like how the TCL part is used. The idea is that the C++ code handle content and the TCL code handle presentation. As it is implemented now it is very hard to change how the weather data is presented. For example I wanted to change the spacing between items. That was not possible since all items is just passed to the TCL even handler script as a list of words. You could just as well have skipped the TCL script and played the sounds directly in the C++ code. What if you don't want to play one item? What if words should be read in a different order in another language? I think it would be better to have one TCL function per item. Then it would be easy to spot which function to modify if you want to change how one of the items are played back. I call the TCL scripts "event handler" because it should handle events. "play_temperature 10" is an event but "say temperature 1 0 degrees" I would call an action. The latter is just a function call that play a series of pre-determined sound clips. Also, as I said the last time, the central functions for playing back numbers and time should be used. I understand that it can be a problem if you want to experiment with another voice but then it would be better to modify the playNumber and playTime fuctions to first look among the module specific sounds and if the sound clips are not found there, use the core sound clips. Sorry, I hope you don't think I'm to hard on you because I really appreciate your contributions to the project. I hope you (all) keep contributing. I just want the whole of SvxLink to behave in a consistent way, both on the air and for configuration, TCL scripts included. 73's de SM0SVX / Tobias > > 73 de DF1AMB, Martin > > > 73's de SM0SVX / Tobias > > > > > 73's de Adi, DL1HRC > > > > ------------------------------------------------------------------------- > >-- --- Come build with us! The BlackBerry(R) Developer Conference in SF, > > CA is the only developer event you need to attend this year. Jumpstart > > your developing skills, take BlackBerry mobile applications to market and > > stay ahead of the curve. Join us from November 9 - 12, 2009. Register > > now! http://p.sf.net/sfu/devconference > > _______________________________________________ > > Svxlink-devel mailing list > > Svx...@li... > > https://lists.sourceforge.net/lists/listinfo/svxlink-devel > |