Remove users from repository as non-admin repository owner
Brought to you by:
mverkerk
When I create a repository (svnmanager version 1.10) and give it to a non-admin user as an owner, this owner is unable to remove users from the repository. Instead the following error message appears:
[8] Undefined variable: s_reposid (@line 314 in file /var/www/svn/svnmanager/svnmanager/RepositoryModule/UserPrivilegesEditPage.php). Debug Backtrace #1 UserPrivilegesEditPage.php:314 -- pradoErrorHandler(...) #2 TComponent.php:550 -- UserPrivilegesEditPage->onRemovePrivileges(...) #3 TRepeater.php:460 -- TComponent->raiseEvent(...) #4 TRepeater.php:437 -- TRepeater->onItemCommand(...) #5 TControl.php:602 -- TRepeater->onBubbleEvent(...) #6 TRepeaterItem.php:185 -- TControl->raiseBubbleEvent(...) #7 TControl.php:602 -- TRepeaterItem->onBubbleEvent(...) #8 TLinkButton.php:212 -- TControl->raiseBubbleEvent(...) #9 TLinkButton.php:187 -- TLinkButton->onCommand(...) #10 TPage.php:1005 -- TLinkButton->raisePostBackEvent(...) #11 TPage.php:950 -- TPage->handlePostBackEvent() #12 TApplication.php:483 -- TPage->execute() #13 index.php:5 -- TApplication->run()
Users marked as admin can remove users from this repository.
IMHO the error is in UserPrivilegesEditPage.php:313. The line
$s_reposid = $this->Module->Database->qstr($s_reposid);
should be
$s_reposid = $this->Module->Database->qstr($reposid);
I changed and tested it in our installation and now it seems to work.
Thank you,
That's seam to work :-)