#54 Creation of group in authz file doesnt check deleted user.

[michael melin]

Empty group are created and causing 403 error for every access:
Failed to load the AuthzSVNAccessFile: An authz rule refers to group '@monitoring-dev', which is undefined

If i'm right, the function getGroupMembers() in createAuthFiles.php need to check deleted user-group or deleted user like:

function getGroupMembers( $groupid, $dbh ) {

global $CONF;

$schema                             = db_determine_schema();

$members                            = array();
$query                              = "  SELECT userid " .
                                      "    FROM ".$schema."svnusers, ".$schema."svngroups, ".$schema."svn_users_groups " .
                                      "   WHERE (svngroups.id = $groupid) " .
                                      "     AND (svngroups.id = svn_users_groups.group_id) " .
                                      "     AND (svnusers.id = svn_users_groups.user_id) " .
                                      "     AND (svn_users_groups.deleted='00000000000000') ".
                                      "     AND (svnusers.deleted='00000000000000') ". 
                                      "ORDER BY userid ASC";
$result                             = db_query( $query, $dbh );
while( $row = db_assoc( $result['result'] ) ) {
    $members[]                      = $row['userid'];
}

return $members;

}

[Thomas Krieger]

Hi Michael,

you are right.

Sorry for the log delay. I added the two missing lines to the query and will create a new release soon.

Regards

Thomas