Thread: [Super-tux-devel] Have you ever heard about the "herring_song" ?

Brought to you by: wkendrick

This project can now be found here.

super-tux-devel

[Super-tux-devel] Have you ever heard about the "herring_song" ?

From: Duong-Khang N. <neo...@us...> - 2003-12-23 22:58:29

Attachments: supertux-herring-song.patch.bz2

Changes:

1. some useless #include removed

2. PLEASE do not "if (use_sound == something)" in gameloop.c ! Its value is 
set by setup.c and then tested by sound.c, that's all.

3. Did some indentations

4. Minor bug fixed: you can now kick the flatten laptop to the left

5. Minor bug fixed: "time_left" now loaded correctly

6. IMHO: in C, we should declare all variables at the beginning of the
function's definition, but not between functions' instructions.

7. Added #define TUX_INVINCIBLE_TIME

8. "song" is now "level_song"

9. with NOSOUND, level_song, herring_song, sounds is now type "void*"

10. Added: playing different songs in one level is now supported (now we need
new songs !)
        NO_MUSIC: no song :(
        LEVEL_MUSIC: play the level_song
        HERRING_MUSIC: play the herring_song
        HURRYUP_MUSIC: guess it ^^

Re: [Super-tux-devel] Have you ever heard about the "herring_song" ?

From: Tobias <tob...@gm...> - 2003-12-23 23:14:29

Thanks for your work, but please don't send any patches until Christmas
is over, because I want to make a stable release NOW. ;)

Greetz...

Tobias Gläßer


Am Di, den 23.12.2003 schrieb Duong-Khang NGUYEN um 17:59:
> Changes:
> 
> 1. some useless #include removed
> 
> 2. PLEASE do not "if (use_sound == something)" in gameloop.c ! Its value is 
> set by setup.c and then tested by sound.c, that's all.
> 
> 3. Did some indentations
> 
> 4. Minor bug fixed: you can now kick the flatten laptop to the left
> 
> 5. Minor bug fixed: "time_left" now loaded correctly
> 
> 6. IMHO: in C, we should declare all variables at the beginning of the
> function's definition, but not between functions' instructions.
> 
> 7. Added #define TUX_INVINCIBLE_TIME
> 
> 8. "song" is now "level_song"
> 
> 9. with NOSOUND, level_song, herring_song, sounds is now type "void*"
> 
> 10. Added: playing different songs in one level is now supported (now we need
> new songs !)
>         NO_MUSIC: no song :(
>         LEVEL_MUSIC: play the level_song
>         HERRING_MUSIC: play the herring_song
>         HURRYUP_MUSIC: guess it ^^
--

Re: [Super-tux-devel] Have you ever heard about the "herring_song" ?

From: Tobias <tob...@gm...> - 2003-12-23 23:25:15

*fluster: And I have written a MENU! :)

Greetz...

Tobias Gläßer

Am Mi, den 24.12.2003 schrieb Tobias Gläßer um 00:13:
> Thanks for your work, but please don't send any patches until Christmas
> is over, because I want to make a stable release NOW. ;)
> 
> Greetz...
> 
> Tobias Gläßer
> 
> 
> Am Di, den 23.12.2003 schrieb Duong-Khang NGUYEN um 17:59:
> > Changes:
> > 
> > 1. some useless #include removed
> > 
> > 2. PLEASE do not "if (use_sound == something)" in gameloop.c ! Its value is 
> > set by setup.c and then tested by sound.c, that's all.
> > 
> > 3. Did some indentations
> > 
> > 4. Minor bug fixed: you can now kick the flatten laptop to the left
> > 
> > 5. Minor bug fixed: "time_left" now loaded correctly
> > 
> > 6. IMHO: in C, we should declare all variables at the beginning of the
> > function's definition, but not between functions' instructions.
> > 
> > 7. Added #define TUX_INVINCIBLE_TIME
> > 
> > 8. "song" is now "level_song"
> > 
> > 9. with NOSOUND, level_song, herring_song, sounds is now type "void*"
> > 
> > 10. Added: playing different songs in one level is now supported (now we need
> > new songs !)
> >         NO_MUSIC: no song :(
> >         LEVEL_MUSIC: play the level_song
> >         HERRING_MUSIC: play the herring_song
> >         HURRYUP_MUSIC: guess it ^^
--

Re: [Super-tux-devel] Have you ever heard about the "herring_song" ?

From: Tobias <tob...@gm...> - 2003-12-23 23:35:32

You write comments like "We're in C, not in C++" *eh ;)
But you WRITE C++ comments! // <- C++ /* <- C :)

Greetz...

Tobias Gläßer

Am Di, den 23.12.2003 schrieb Duong-Khang NGUYEN um 17:59:
> Changes:
> 
> 1. some useless #include removed
> 
> 2. PLEASE do not "if (use_sound == something)" in gameloop.c ! Its value is 
> set by setup.c and then tested by sound.c, that's all.
> 
> 3. Did some indentations
> 
> 4. Minor bug fixed: you can now kick the flatten laptop to the left
> 
> 5. Minor bug fixed: "time_left" now loaded correctly
> 
> 6. IMHO: in C, we should declare all variables at the beginning of the
> function's definition, but not between functions' instructions.
> 
> 7. Added #define TUX_INVINCIBLE_TIME
> 
> 8. "song" is now "level_song"
> 
> 9. with NOSOUND, level_song, herring_song, sounds is now type "void*"
> 
> 10. Added: playing different songs in one level is now supported (now we need
> new songs !)
>         NO_MUSIC: no song :(
>         LEVEL_MUSIC: play the level_song
>         HERRING_MUSIC: play the herring_song
>         HURRYUP_MUSIC: guess it ^^
--

Re: [Super-tux-devel] Have you ever heard about the "herring_song" ?

From: Bill K. <nb...@so...> - 2003-12-24 01:21:04

On Tue, Dec 23, 2003 at 11:59:58PM +0100, Duong-Khang NGUYEN wrote:
> 
> 6. IMHO: in C, we should declare all variables at the beginning of the
> function's definition, but not between functions' instructions.

!!!  Who did that!?   (Glaring at Tobias)

;)

> 7. Added #define TUX_INVINCIBLE_TIME
> 
> 8. "song" is now "level_song"
> 
> 9. with NOSOUND, level_song, herring_song, sounds is now type "void*"
> 
> 10. Added: playing different songs in one level is now supported (now we need
> new songs !)
>         NO_MUSIC: no song :(
>         LEVEL_MUSIC: play the level_song
>         HERRING_MUSIC: play the herring_song
>         HURRYUP_MUSIC: guess it ^^

Cool!  Thanks, DK!  (I hope I can call you that for short ;) )


-- 
bi...@ne...                           Got kids?  Get Tux Paint! 
http://newbreedsoftware.com/bill/       http://newbreedsoftware.com/tuxpaint/

Re: [Super-tux-devel] Have you ever heard about the "herring_song" ?

From: Tobias <tob...@gm...> - 2003-12-24 01:26:57

Hey, aren't C++ tweaks backwards compatible to C *eh ?

:))

ok ok

Greetz...

Tobias Gläßer (a master in lazy evaluation ;) )

Am Di, den 23.12.2003 schrieb Bill Kendrick um 20:21:
> On Tue, Dec 23, 2003 at 11:59:58PM +0100, Duong-Khang NGUYEN wrote:
> > 
> > 6. IMHO: in C, we should declare all variables at the beginning of the
> > function's definition, but not between functions' instructions.
> 
> !!!  Who did that!?   (Glaring at Tobias)
> 
> ;)
> 
> > 7. Added #define TUX_INVINCIBLE_TIME
> > 
> > 8. "song" is now "level_song"
> > 
> > 9. with NOSOUND, level_song, herring_song, sounds is now type "void*"
> > 
> > 10. Added: playing different songs in one level is now supported (now we need
> > new songs !)
> >         NO_MUSIC: no song :(
> >         LEVEL_MUSIC: play the level_song
> >         HERRING_MUSIC: play the herring_song
> >         HURRYUP_MUSIC: guess it ^^
> 
> Cool!  Thanks, DK!  (I hope I can call you that for short ;) )
--