Re: [Super-tux-devel] Bad guys fixes [patch]

[Tobias <tob...@gm...>]

Am Sa, den 13.03.2004 schrieb Ricardo Cruz um 19:48:
> Hey there,
> 
>  This patch fixes a few issues (not all!) from bad guys, give it a try. (the 
> patch is small, but gave some work, so appreciate it! ;) )

Of course, I do. :)

>  The following bugs should be fixed:
> - When Tux is big and is stopped, laptop does not harm him. This is a result 
> of the fact that now collisions are not tested upon the velocity, but 
> player's position and size;
> - When laptop is being hold, you are invincible. This is a gameplay issue, 
> laptop could be destroyed/kicked after the first enemy killed or/and player 
> could only hold the laptop for a few time.

I'd say the laptop should be destroyed after the first enemy is kicked.

>  Collision system should be studied a little more, since there seem to be a 
> few issues, regarding it.

You mean collisions between game objects, right? Yeah, that's true!
For game-object with map collisions I'd say there is only one known bug,
which occurs in a very special situation with low frames, so we can
nearly say it was perfect.

>  There was this bug:
> if(pbad->dir = LEFT)
>  (line 174 badguys.c)
>  Shouldn't gcc said anything? We are using -Wall... At least, g++ would have 
> warn about that.

This compilers are playing tricks on us. :(

>  Tobias, I sent a few time ago, a patch for making the powerups going in the 
> opposite direction of the side that the player collided with the brick... It 
> looks like that isn't being done, wanna me to patch that again?

I applied that patch. Dunno why it isn't working anymore. :(

Greetz...

Tobias Gläßer
--