[Super-tux-devel] Alternative keys to control the game

[Hernani M. M. <he...@tu...>]

Hello @ all.

Are there any objections against including the following key combinations
to control the game (as they are implemented in snes9x):

<GAMELOOP>
--- gameloop.c.orig	2004-02-21 22:51:50.000000000 +0100
+++ gameloop.c	2004-02-21 23:19:25.000000000 +0100
@@ -176,7 +176,7 @@
 
           key = event.key.keysym.sym;
 
-          if (key == SDLK_ESCAPE)
+          if (key == SDLK_ESCAPE || key == SDLK_q)
             {
               /* Escape: Open/Close the menu: */
               if(!game_pause)
@@ -187,23 +187,23 @@
                     show_menu = 1;
                 }
             }
-          else if (key == SDLK_RIGHT)
+          else if (key == SDLK_RIGHT || key == SDLK_k)
             {
               right = DOWN;
             }
-          else if (key == SDLK_LEFT)
+          else if (key == SDLK_LEFT || key == SDLK_h)
             {
               left = DOWN;
             }
-          else if (key == SDLK_UP)
+          else if (key == SDLK_UP || key == SDLK_c)
             {
               up = DOWN;
             }
-          else if (key == SDLK_DOWN)
+          else if (key == SDLK_DOWN || key == SDLK_j)
             {
               down = DOWN;
             }
-          else if (key == SDLK_LCTRL)
+          else if (key == SDLK_LCTRL || key == SDLK_e)
             {
               fire = DOWN;
             }
@@ -218,23 +218,23 @@
           if(show_menu)
             menu_event(key);
 
-          if (key == SDLK_RIGHT)
+          if (key == SDLK_RIGHT || key == SDLK_k)
             {
               right = UP;
             }
-          else if (key == SDLK_LEFT)
+          else if (key == SDLK_LEFT || key == SDLK_h)
             {
               left = UP;
             }
-          else if (key == SDLK_UP)
+          else if (key == SDLK_UP || key == SDLK_c)
             {
               up = UP;
             }
-          else if (key == SDLK_DOWN)
+          else if (key == SDLK_DOWN || key == SDLK_j)
             {
               down = UP;
             }
-          else if (key == SDLK_LCTRL)
+          else if (key == SDLK_LCTRL || key == SDLK_e)
             {
               fire = UP;
             }
@@ -286,7 +286,7 @@
               /* Handle joystick for the menu */
               if(show_menu)
                 {
-                  if(down == DOWN)
+                  if(down == DOWN) 
                     menuaction = MN_DOWN;
                   else
                     menuaction = MN_UP;
@@ -2330,7 +2330,6 @@
 
 
   /* Load data file: */
-
   filename = (char *) malloc(sizeof(char) * (strlen(DATA_PREFIX) + 20));
   sprintf(filename, "%s/levels/level%d.dat", DATA_PREFIX, level);
   fi = fopen(filename, "r");
</GAMELOOP>

--

<MENU>
--- menu.c.orig	2004-02-21 22:51:57.000000000 +0100
+++ menu.c	2004-02-21 22:50:58.000000000 +0100
@@ -219,21 +219,21 @@
 {
 
 
-  if (key == SDLK_UP)
+  if (key == SDLK_UP || key == SDLK_u)
     {
       /* Menu Up */
 
       menuaction = MN_UP;
       menu_change = YES;
     }
-  else if (key == SDLK_DOWN)
+  else if (key == SDLK_DOWN || key == SDLK_j)
     {
       /* Menu Down */
 
       menuaction = MN_DOWN;
       menu_change = YES;
     }
-  else if (key == SDLK_SPACE || key == SDLK_RETURN)
+  else if (key == SDLK_SPACE || key == SDLK_RETURN || key == SDLK_c)
     {
       /* Menu Hit */
 </MENU>

Alternatively -- with low priority -- a menu item giving one the option to define
custom key combinations _could_ make this depreciated. Nevertheless I think that
having an additional standard set defined that 10 finger gamers could use
is not the baddest idea ;).

Hernani