Re: [Super-tux-devel] Current rewrite/restructuring status commited!

[Tobias <tob...@gm...>]

Am So, den 18.01.2004 schrieb Ricardo Cruz um 03:49:
> Hey Tobias,
> 
>  It is really damn cool that now each object has its own file ;) Great work!
>  I wanted to fix the fact that when a bad guys is falling or being squashed, 
> the Tux image overlaps the bad_guy one. Now this can be easily achieved, 
> since everyone has its own drawing funcs.
>  Gameloop.c has been reduced in 45% :)) It's also a good suprise to see much, 
> much less global variables.
> 

snip
>  In the screen.c, maybe funcs pointers should be used, instead of if's...
>  There are some filenames that I don't like that much and don't really show 
> what they do (special, scene and world). I'll make suggestions later.
>  And stuff in type.c should go to the screen.c and gameloop.c or a timer.c 
> file.
snap

I fully agree. As I said it's isn't perfect and I would have done the
whole things you describe here, if I had more time.
I'd really like a few suggestions for the filenames. Timer.c is very
obvious and good for example.

>  About the gameplay, there are a few very visible bugs :) not sure how hard 
> are they to be fixed.

I know. :) Some of them can be fixed by fine-tuning #defines. Other bugs
like the FIXME-gameplay-bug-#1 will unfortunately need much more work.

>  Right now, I have made a minor patches. It replaces all those evil if's in 
> the game_event() by switches. When Ctrl was being pressed Tux was walking, 
> instead of running, and vice-versa, it also fixes this thing.

A patch? Cool! Where is it? I can't see attached to your mail. :( Or do
you mean, you have commited it to CVS already?

Greetz...

Tobias Gläßer