Re: [Super-tux-devel] Sound (again) bugs fixed

[Tobias <tob...@gm...>]

Am Mi, den 24.12.2003 schrieb Duong-Khang NGUYEN um 13:37:
> Changes:
> 
> 1. Bug fixed: start with sound off (via menu) then sound on (via menu) didn't
> work. Now it works correctly.
> 
> 2. Changes introduced by the point 1: sound.c will load song and music even if
> "use_sound" is 0
> 
> 3. Fixed memory leaks in sound/song/gfx un/loading. It's just a temporary 
> solution until the point 4 is fixed.
> 

snip
> 4. IMHO: one function should have only one return instruction. Multiple return
> statements are the cause of bug in point 3.

That's not my opinion."Returns" can be an instrument to leave a function
as fast as possible and to save time. It is MY fault, that I forgot to
put the unload-functions before the return!

I'll do what I forgot previously. Putting the unload-functions before
the return statement.

Greetz...

Tobias Gläßer


--