Menu

#35 (PRIORITY) SRT files broken and the open dialog is now a legacy dialog

2.0
closed
nobody
None
2024-04-27
2024-04-20
Templayer
No

With the new version, the open dialog has been switched to a legacy one.

I can no longer see all subtitle files, instead I have to specifically choose the format.

I could only find one .srt format, and opening my srt files (which were produced by youtube+JDownloader) cannot be opened, yet they were opened fine in the previous version. See the attachment. It is possible that they are named srt, but are something else. Youtube is retarded, so I wouldn't put it past them.

How do I enable the non-legacy file picker (and revert this change)? It took me ten minutes going through the humongous list of formats over and over, whereas in the previous version it took a second or two to select a file and that's it. I find that unacceptable and I will have to revert the Subtitle Workshop version to be able to work on my subtitles (even though these are legacy subtitles that I am converting to a newer format and fixing them up).

The legacy file picker doesn't even allow me to input a path (i.e. copypaste the path to enter a folder), so I have to manually travel across my harddrive in it to get into a specific path. I'm working 40+ hours a week, I really don't have the time for that...

3 Attachments

Discussion

  • Templayer

    Templayer - 2024-04-20

    Looks like this is an issue proper. I have used https://gotranscript.com/subtitle-converter to convert it to an srt just in case mine is wrong somehow, and the issue was the same.

    So I checked and this is a proper issue. The app essentially breaks when it gets the result of the legacy modal file picker.

    When I select SubViewer 2.0 in the file picker window, and then select a sub file that was created as SubViewer 2.0 file via Subtitle Workshop, it tells me that it isn't a proper SubStation Alpha file. Which is a totally different file extension, so if I were choosing SubStation Alpha, I wouldn't even be able to pick the file, as the file is .sub.

    Some really broken is going on. I'll try limiting the file picker options to bare minimum to see if it works.

     
    • Templayer

      Templayer - 2024-04-20

      (the reason why I haven't encountered this that I am always either opening subtitles from Recent, or saving/creating a new one. It's rare for me to open an old subtitle that isn't in Recent)

       
      • Templayer

        Templayer - 2024-04-20

        Looks like the Settings only allow me to limit the formats in the Save as... dialog window, not the file picker window for loading subtitles.

        Bollocks.

        Welp.

        I'll attach my settings.

         
        • Templayer

          Templayer - 2024-04-20

          Found a workaround. The file picker is broken, but if I go around it (using the Recent files for example), it works. This gave me an idea - I just drag&dropped the file into Subtitle Workshop and now it works. Voilá!

          I haven't encountered this behavior before. Other applications still use the non-legacy file picker window, and I have never encountered the "switcharoo" of the types upon returning the result from the file picker window into the application. It's weird.

          Other than changing my system font colour I do not remember doing anything else in the past few months. So I have no clue what could've caused such behavior if the issue is on my side.

           
          • Templayer

            Templayer - 2024-04-20

            The video file picker is now legacy too, but at least it does load videos correctly.

             
            • Templayer

              Templayer - 2024-04-20

              I tested multiple other applications that use the non-legacy file picker for opening files, and none of them has been changed to a legacy one, so I do not think that issue is on my side. Could be wrong, of course - as always.

               
  • Kameleon_

    Kameleon_ - 2024-04-22

    I will look at this as soon aspossible. Thanks for the problem report!

     
    ❤️
    1
  • Kameleon_

    Kameleon_ - 2024-04-23

    I can no longer see all subtitle files, instead I have to specifically choose the format.

    The attached version should be Ok.
    My mistake... Sorry for the inconvenience.

     

    Last edit: Kameleon_ 2024-04-23
    • Templayer

      Templayer - 2024-04-24

      I'll check it out during the weekend.

       
  • Kameleon_

    Kameleon_ - 2024-04-23

    I assume that you mean with "the legacy" the apperance of the open dialog? Working on it to use the same apperance as in the batchconvert first window (selectIon of the paths). I think that is what you want.

     
    • Templayer

      Templayer - 2024-04-23

      I mean that is one way of doing that.

      I originally meant using non-legacy file picker from Windows. Native. The one that can be configured and stylized, and applies to all dialogs of the same type, no matter the application (as long as the application uses the non-legacy variant, that is).

      Please note that mine is heavily stylized, and looks like this in multiple applications - the one in the attachment was produced by Firefox. And notice the path bar.

      This is also how the subtitle loading file picker dialog looked like in 6.2.9 test version 4 and how it has always looked like for me. After updating, it uses the legacy file picker, as shown in the main issue attachment (and not in this comment attachment).

       
      • Templayer

        Templayer - 2024-04-23

        Try comparing this https://sourceforge.net/p/subtitle-workshop-classic/tickets/35/attachment/Legacy%20file%20picker.png

        with this https://sourceforge.net/p/subtitle-workshop-classic/tickets/_discuss/thread/7f41babc84/c9f3/e69f/attachment/non-legacy%20file%20picker%20dialog.png

        side by side. Both are native Windows file pickers, but one is legacy and one is newer. Somehow, the application now uses the legacy one after changes after version 6.2.9 test version 4.

        I haven't tried your fixed version yet.

         
        • Templayer

          Templayer - 2024-04-23

          Also, clicking the Browse button in the batch convert window produces the correct non-legacy native folder picker window. Which also has a legacy and non-legacy variant.

          For a moment I thought you were going to make your own.

           

          Last edit: Templayer 2024-04-23
          • Kameleon_

            Kameleon_ - 2024-04-23

            No, I will not make my own. I will use this one to e.g. open subtiles, projects and movies.

             
            • Kameleon_

              Kameleon_ - 2024-04-24

              By the way: All open and save dialogs suffer from the 'native' look since the darkmode has been introduced, not only 'load subtitle'. They will all be replaced in v6.2.11.

               
              • Templayer

                Templayer - 2024-04-24

                The 'native' looking dialogs aren't the problem. Them using the legacy 'native' pickers instead of non-legacy 'native' picker is.

                I hope we understand each other. Hmm. I could try making a video. Or maybe we could actually talk.

                 
                • Kameleon_

                  Kameleon_ - 2024-04-25

                  Hi, can you check the newly released version v6.2.11 please?
                  Thanks in advance.

                  Also this issue should be solved in this version:

                  I can no longer see all subtitle files, instead I have to specifically choose the format.
                  So I checked and this is a proper issue. The app essentially breaks when it gets the result of the legacy modal file picker.

                   
                  👍
                  1

                  Last edit: Kameleon_ 2024-04-26
                  • Templayer

                    Templayer - 2024-04-27

                    Everything seems to be fixed now! Thank you!

                     
  • Kameleon_

    Kameleon_ - 2024-04-27
    • status: open --> closed
     

Log in to post a comment.