Cancelling the "Load subtitle" modal window reloads the video for some reason
Subtitle Editor derived from 6.0c, but with VLC and Hunspell checker
Brought to you by:
kameleon
Menu
▾
▴
#27 Cancelling the "Load subtitle" modal window reloads the video for some reason
I just found that out by a mistake.
Instead of clicking on the Save button on the toolbar, I clicked on the "Load subtitle" button on the left of it.
Then I proceeded to close the modal window without loading any subtitle (thus keeping my current subtitle file open and not opening any subtitle) by clicking on the cancel button in the modal window.
For some reason, this has closed and reopened the video.
Which is a bit annoying, if the video in question is in 2K or 4K and not on an SSD... as I have to wait a bit. For no apparent reason.
I have tested it and I am capable of duplicating the issue by doing the same steps as I have described.
Maybe this should be solved together with https://sourceforge.net/p/subtitle-workshop-classic/tickets/22/
Because there should be checks if the video needs to be closed and reloaded.
Hi Templayer,
Could you check please if the problem stated in this ticket and the change requested in ticket 22 are indeed solved and implemented?
Thanks in advance.
The change from this ticket works as it should.
The change from the other ticket does not, however.
Steps to reproduce the problem:
1. Load a project that will load a subtitle that will also load a video file.
2. Now save as a different subtitle file (I just added TEST at the end).
3. Go to recent and open the original subtitle that you just made a copy of.
4. The video gets closed just to be opened again.
5. Going into recent and clicking on the original subtitle file also reopens the video.
Instead of reopening it, it should just seek to the last time on the timeline if the video is identical.
Indeed. I tested with VLC renderer but I see that the VMR renderer behaves differently. Until now there was an extra workaround for VMR (implemented before my time) which reloaded the video every time an audio track was selected (and this happens e.g. when a movie is loaded). I think this is the reason for the problem.
I made a version for you that does not the mentioned workaround any more. I can not test it however, I do not use any more the classic video renderers (I use VLC).
Could you test it please?
Thanks in advance!
Seems to be working correctly.
I also tried switching between both subtitles and projects, switching with subtitles that have a different video (video is switched correctly as well) and switching to a subtitle that is connected to a video that is no longer available - I would be expecting for the video to close, but maybe it being kept open in that case might be more useful in fringe cases, so I would leave that one as it is.
Good job.
What I forgot to test was the timeline seeking - if I switch between subtitles that are referencing the same video, but have different seek times on the timeline, the timeline should move. I can leave the testing of that to you, hopefully.
Yes, I will do the timeline seeking check.
But You can do another test: please check if the audio stream selection for the vmr renderers is still ok. The removal of the workaround can have an efeect on it. I know it seems unrelated but I suspect possible problems there.
Thanks in advance.
What manner of testing do you have in mind? What exactly should I test?
The audio stream selection in movies with more than one audiostream, via menu "movie, audio stream".
Thanks in advance.
Hi Templayer,
There was still a problem with the timeline (last selected position in the movie) when loading a project when the movie was unchanged. This is solved in the attached version. :-)
Last edit: Kameleon_ 2024-02-07
Tested timelines and audio tracks.
Two subtitles referencing one video, with two audio tracks and two spots on the timeline per each subtitle file.
Opening the other subtitle back and forth moves the position on the timeline correctly AND it also switches the audio track to what the currently-being-opened subtitle was using on the video.
It's possible that I am missing something, but it looks like it is working correctly.
Great job!
Nice. Thanks for the testing!
And thanks you for making the most complex subtitle creation tool even better!
And now about that Linux version... :D :D
Solved in v6.2.9.