Direct calls of class' constructors are no longer allowed by gcc-4.5. As a result Subtitle Composers fails to build with latest gcc.
Downstream bug report: http://bugs.gentoo.org/show_bug.cgi?id=323055
Error: (see downstream bug for build.log)
[ 17%] [ 18%] In file included from /var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/subtitle.cpp:20:0:
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/subtitle.h:186:35: warning: type qualifiers ignored on function return type
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/config/appconfiggroupwidget.cpp:42:58: warning: type qualifiers ignored on function return type
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.cpp:1115:33: error: ‘SubtitleComposer::SStringList::SStringList’ names the constructor, not the type
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.cpp:1115:59: error: ISO C++ forbids declaration of ‘list’ with no type
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.cpp:1115:1: error: prototype for ‘SubtitleComposer::SStringList::SStringList(const int&)’ does not match any in class ‘SubtitleComposer::SStringList’
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.h:48:4: error: candidates are: SubtitleComposer::SStringList::SStringList(const QList<QString>&)
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.h:47:4: error: SubtitleComposer::SStringList::SStringList(const QStringList&)
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.h:46:4: error: SubtitleComposer::SStringList::SStringList(const QList<SubtitleComposer::SString>&)
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.h:45:4: error: SubtitleComposer::SStringList::SStringList(const SubtitleComposer::SStringList&)
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.cpp:1110:1: error: SubtitleComposer::SStringList::SStringList(const SubtitleComposer::SString&)
/var/tmp/portage/media-video/subtitlecomposer-0.5.3/work/subtitlecomposer-0.5.3/src/core/sstring.cpp:1106:1: error: SubtitleComposer::SStringList::SStringList()
Please note that attached patch is backward compatible, i.e. works with gcc < 4.5
Best regards,
Kacper Kowalik
fixing build with gcc 4.5