Menu

#1 comment handling patch

closed-accepted
parser (1)
5
2001-07-28
2001-07-21
No

``states.py``:
* swallow empty comments

``test_states.py``:
* test swallowing of empty comments
* test comments indented in bullets and block quotes
* test comments used to outdent (**FAILS**)

Discussion

  • David Goodger

    David Goodger - 2001-07-21

    Logged In: YES
    user_id=7733

    The patch itself is not attached. Is this the file you sent
    by email Garth? Please reattach.

     
  • David Goodger

    David Goodger - 2001-07-21
    • labels: --> parser
    • assigned_to: nobody --> goodger
     
  • Garth T Kidd

    Garth T Kidd - 2001-07-25

    a diff, NOT a patch

     
  • Garth T Kidd

    Garth T Kidd - 2001-07-25

    Logged In: YES
    user_id=59803

    Attached diff. Sorry about that.

    It's not a patch because rdiff only works between versions
    checked into the repository, something in my local
    repository broke, and I don't yet have access to the
    project repository. I'll make proper patches when I can. :)

     
  • David Goodger

    David Goodger - 2001-07-28

    Logged In: YES
    user_id=7733

    states.py 1.2: doesn't "swallow" empty comments, but
    fixed it so outdenting doesn't fail (I'm not 100% sure this
    is the right thing to do though).

    test_states.py 1.2: added most test cases (but empty
    comments remain).

    BTW, supplied .diff worked just fine with patch. Thanks!

     
  • David Goodger

    David Goodger - 2001-07-28
    • status: open --> closed-accepted
     

Log in to post a comment.