From: Roland M. <ro...@re...> - 2007-05-24 03:51:17
|
That seems right in essence. Some nits: For Linux-specific code don't trust <sys/syscall.h> to have everything. Use <asm/unistd.h> and __NR_foo names. Current best practice is tgkill, which newer 2.6.x has. 2.4 does not have tkill, and strace works (probably still) on 2.4. So, define a function or macro that uses tgkill #ifdef __NR_tgkill, fall back to tkill #ifdef __NR_tkill, fall back to kill. Since this issue has a Fedora bugzilla report, note existing ChangeLog precedent and add "Fixes RH#nnn." at the end of the log entry. Thanks, Roland |