Re: [PATCH] s390: New syscalls for 2.6.17

[Michael H. <HO...@de...>]

Dmitry,

> On Mon, Sep 04, 2006 at 10:51:19AM +0200, Michael Holzheu wrote:
> > This patch adds the new syscalls of 2.6.17 for the architectures
> > s390 and s390x. Roland, could you please integrate this patch?
>
> Michael, could you please check for my patch #135427 attached to
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=178633
> - it should already contain all necessary changes.

Looks good! Two comments:

For s390 (not s390x!) you should change

+     { 4,  TD|TD,      sys_newfstatat,         "newfstatat"      }, /* 293
*/
to
+     { 4,  TD|TF,      printargs,        "fstatat64" }, /* 293 */

... and in gereral I think you should change

+      { 4,    TD|TF,  printargs,              "linkat"        }, /* 296 */
to
+      { 5,    TD|TF,  printargs,              "linkat"        }, /* 296 */

Will your patch be integrated into source forge strace CVS?

Thanks

Michael